345311 - Content-Disposition is ignored on download retry

Status: NEW

(Toolkit :: Downloads API, defect, P3)

Description

[u39892]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1

When restarting a download, the Content-Disposition header is ignored, and filename is based on the URL instead.

Reproducible: Always

Steps to Reproduce:
1. Go to http://bowmore.dcs.st-andrews.ac.uk/mms/DownloadTest
2. Click cancel on the download
3. Click restart on the download

Actual Results:  
A new download, with the file name "Download.htm" appears

Expected Results:  
File name should stay as "dsl-3.0.iso"

Comment 1

[Adam Guthrie]

Might be related to bug 299372.

Comment 2

[Jackie Liu]

This bug seems to be present in build: 2006072103 (latest nightly build).  This should probably be confirmed, but I don't have "canconfirm" privileges, yet.

Comment 3

[Jackie Liu]

This problem continues to appear in newer nightlies.  I'm using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060727 BonEcho/2.0b1 right now as I speak. 

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This happens because getDefaultFileName() prefers using the filename from the URI over the default filename that was passed in to saveURL(). So when saveURL is called from onDownloadRetry, the passed in filename is ignored.

(As a sidenote, onDownloadRetry passes a nsILocalFile object to saveURL instead of a string, which is what it expects. Good thing that argument is ignored! :/)

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/downloads/content/downloads.js&rev=1.55&mark=445,446#440
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/contentAreaUtils.js&rev=1.85&mark=838-840,858#809

I don't think this depends on bug 356086, because the download retrying code no longer has access to the original channel. It has access to the original filename, it just doesn't use it correctly.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: incomplete patch

This fixes it, but I'm not sure that it correctly handles all cases.

(the testcase in comment 0 is 404, by the way)

Comment 6

[u39892]

Test case resurrected, sorry about that.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Is this bug still present?

Comment 8

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.