345353 - Compatibility Wizard string changes

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Spinoff of bug 342606.

I also folded in your and Reed's comments to get: 

screen 1: 
   panel title: "Checking Add-ons Compatibility"
   progress text: "Checking your add-ons…"

screen 2:
   panel title: "Found Incompatible Add-ons"
   text: "The following add-ons are not compatible with this version of %S and
have been disabled:"
   text: "%S can check to see if compatible updates to these add-ons are
available."

screen 3:
   panel title: "Checking for Compatibility Updates"
   text: "Checking for available updates to incompatible add-ons…"
   progress text: "Checking for update to %S."

screen 4:
   panel title: "Unable to Install Updates"
   text: "There are updates available, but they can't be installed because
software installation for %S has been disabled. Please contact your
system administrator for assistance."
   - the "don't check" button should be a disabled "Cancel" button

screen 5:
   panel title: "Found Compatibility Updates"
   text: "Select the updates you would like to install:" 

screen 6:
   panel title: "Found Compatibility Updates"
   text: "Select the updates you would like to install:" 
   text: "The selected updates can't be installed because software installation
is currently disabled. You can change this setting below." 

screen 7:
   panel title: "Installing Compatibility Updates"
   text: "Downloading and installing updates to your add-ons…"
   progress text as current

screen 8:
   panel title: "Compatibility Updates Installed"
   text: "%S has installed the updates to your add-ons."

screen 9:
   panel title: "No Compatibility Updates Found"
   text: "%S was unable to find any updates for your incompatible add-ons. %S
will continue to check periodically and inform you when compatible updates for
these add-ons are found."

screen 10:
   panel title: "Some Compatibility Updates Not Found"
   text: "%S was unable to find any updates for some of your incompatible
add-ons. %S will continue to check periodically and inform you when compatible
updates for these add-ons are found."
   - checkText is good as is

screen 11:
   panel title: "No Compatibility Updates Found"
   text: "%S was unable to find any updates for your incompatible add-ons. %S
will continue to check periodically and inform you when compatible updates for
these add-ons are found."
   - checkText is good as is

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: Pages that have error buttons

I'll hopefully have the rest of the string changes done today.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230564 [details]
Pages that have error buttons

The Error page when installing update(s) gets a uir+, with thanks!

The No updates found page when errors finding update(s), however, should be:

embedded text: "Some problems were encountered when trying to find updates." (this gets rid of the repetition of "Minefield" everywhere, and is a little cleaner)

details page text: "%S was unable to contact the  update servers for the following add-ons:" (my assumption in bug 342606 comment 23 was obviously wrong, so this is a clearer way of expressing the string while still explaining the error that was found)

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> ...
> details page text: "%S was unable to contact the  update servers for the
> following add-ons:" (my assumption in bug 342606 comment 23 was obviously
> wrong, so this is a clearer way of expressing the string while still explaining
> the error that was found)
This can also happen when the update server is available and the rdf is invalid... I'll work on better text.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #3)
> (In reply to comment #2)
> > ...
> > details page text: "%S was unable to contact the  update servers for the
> > following add-ons:" (my assumption in bug 342606 comment 23 was obviously
> > wrong, so this is a clearer way of expressing the string while still explaining

> This can also happen when the update server is available and the rdf is
> invalid... I'll work on better text.

Then maybe just "%S was unable to successfully check for updates to the following add-ons:"

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> Then maybe just "%S was unable to successfully check for updates to the
> following add-ons:"

Can we have "%S was unable to successfully check for updates for the following add-ons:" instead? That's s/updates to/updates for/. :)

Comment 6

[Robert Strong (they/them - no direct email)]

The following reads awkwardly to me...
screen 1: 
   panel title: "Checking Add-ons Compatibility"

Shouldn't Add-ons should be possessive? I'd prefer to go with something like:
   panel title: "Add-ons Compatibility Check"

Also, instead of:
"%S was unable to successfully check for updates to the following add-ons:"

"&brandShortName; was unable to check for updates to the following add-ons:"

"successfully" seems superfluous in this context.

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> The following reads awkwardly to me...
> screen 1: 
>    panel title: "Checking Add-ons Compatibility"
> 
> Shouldn't Add-ons should be possessive? I'd prefer to go with something like:
>    panel title: "Add-ons Compatibility Check"

"Add-ons Compatibility Check" is fine. I'd like to see it as a screenshot, though.

> Also, instead of:
> "%S was unable to successfully check for updates to the following add-ons:"
> 
> "&brandShortName; was unable to check for updates to the following add-ons:"
> 
> "successfully" seems superfluous in this context.

I'm fine with that removal, as long as you do s/updates to/updates for/.

Comment 8

[Reed Loden [:reed]]

We *could* actually do The Proper Thing(tm) and say "Checking Add-ons' Compatibility", but that looks a bit weird.

Can I get a screenshot of both "Checking Add-ons' Compatibility" and "Add-ons Compatibility Check"? I'd like to see how each looks.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: screenshots

Several changes with the main one being that I changed compatibility update because we use that elsewhere when referring to updating the compatibility information for an add-on.

Comment 10

[Robert Strong (they/them - no direct email)]

Attachment: Comparison screenshot for comment #8

Comment 11

[Robert Strong (they/them - no direct email)]

(In reply to comment #7)
> I'm fine with that removal, as long as you do s/updates to/updates for/.
Made the change locally 

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: patch

I'm going to hold off on review until after the ui-review

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230726 [details] [diff] [review]
patch

Rob, first, wanted to thank you for your patience. Reed and I have been going 'round and 'round a lot on IRC, and I know there's been some back and forth. Apologies tendered, but a lot of this wording (as I'm sure you know) is tricky 'cause we're talking about things that will be done to things and ... gah. A couple of more changes due to typos and sober second thoughting:

... to things we've already asked you to change:

+<!ENTITY  checking.wizard.title           "Checking for Compatible Add-ons">
+<!ENTITY  checking.top.label              "Checking your incompatible add-ons for updates&#133;">
+<!ENTITY  installing.introduction.label   "Downloading and installing updates to your add-ons&#133;">
+<!ENTITY  versioninfo.wizard.title        "Checking Compatibility of Add-ons">
+<!ENTITY  versioninfo.intro.label         "Checking your add-ons for compatibility with this version of &brandShortName;.">
+<!ENTITY  installerrors.intro.label       "&brandShortName; encountered problems when updating some of your
+                                           add-ons.">

... and to things we should have previously, but didn't!

+<!ENTITY  checking.status                 "This may take a few minutes&#133;">
+installErrorDesc=%S was unable to install updates for the following add-ons:

With these changes you have my uir.

Comment 14

[Robert Strong (they/them - no direct email)]

(In reply to comment #13)
> (From update of attachment 230726 [details] [diff] [review] [edit])
> Rob, first, wanted to thank you for your patience.
np

> ... to things we've already asked you to change:
> 
> +<!ENTITY  checking.wizard.title           "Checking for Compatible Add-ons">
fixed

> +<!ENTITY  checking.top.label              "Checking your incompatible add-ons
> for updates&#133;">
> +<!ENTITY  installing.introduction.label   "Downloading and installing updates
> to your add-ons&#133;">
The only difference for these two is the use of the html entity and a decimal is fine. No change

> +<!ENTITY  versioninfo.wizard.title        "Checking Compatibility of Add-ons">
fixed

> +<!ENTITY  versioninfo.intro.label         "Checking your add-ons for
> compatibility with this version of &brandShortName;.">
Fixed - this may look funky since it will probably wrap and is above the progress bar

> +<!ENTITY  installerrors.intro.label       "&brandShortName; encountered
> problems when updating some of your
> +                                           add-ons.">
Fixed

> ... and to things we should have previously, but didn't!
> 
> +<!ENTITY  checking.status                 "This may take a few minutes&#133;">
> +installErrorDesc=%S was unable to install updates for the following add-ons:
Fixed

Comment 15

[Robert Strong (they/them - no direct email)]

Attachment: patch

This should be good to go... I'm going to test before requesting review

Comment 16

[Robert Strong (they/them - no direct email)]

btw: in regards to using the unicode char for ellipsis... I've talked with a couple of people and
1) this may not be available on all systems
2) if this is to be the new standard a bug should be filed to change this throughout the tree and that bug should change it for this ui instead of this bug.

Also, if we are to do this it should probably be … which we support and not … which was created by MS and may not be supported on all systems, etc.

Comment 17

[Reed Loden [:reed]]

(In reply to comment #16)
> Also, if we are to do this it should probably be … which we support and
> not … which was created by MS and may not be supported on all systems,
> etc.

… is fine. I can't remember the reason we originally used …. Probably some l10n/l12y issue.

Comment 18

[Robert Strong (they/them - no direct email)]

Also see http://www.w3.org/Talks/1999/0830-tutorial-unicode-mjd/slide27-0.html

As for this bug I am not going to make this file inconsistent with how it was done previously by using … - currently … isn't used in any locale files and I am not willing to use this ui as a testcase to see if it fails on any system for what ever reason due to this change. Please file a bug to change it throughout the tree if you believe this change is needed.

Comment 19

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 20

[Robert Strong (they/them - no direct email)]

Comment on attachment 230812 [details] [diff] [review]
patch

bah... missed changing an entity name for l10n

Comment 21

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 22

[(not reading, please use [e-mail] instead)]

Comment on attachment 230814 [details] [diff] [review]
patch

r=sspitzer

robert explained this face to face.  two minor corrections we found:

1)

Compatibile -> Compatible 

2)

<!ENTITY  details.label                   "Details">

rs says: Details...

Comment 23

[Robert Strong (they/them - no direct email)]

Attachment: patch checked in to trunk

Comment 24

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 25

[Robert Strong (they/them - no direct email)]

*** Bug 345996 has been marked as a duplicate of this bug. ***

Comment 26

[Robert Strong (they/them - no direct email)]

Comment on attachment 230820 [details] [diff] [review]
patch checked in to trunk

Besides the string changes this also fixes a couple of additional long standing bugs in the wizard.

Comment 27

[Mike Connor [:mconnor]]

Comment on attachment 230820 [details] [diff] [review]
patch checked in to trunk

Approving, since we already agreed to take this after baking.  Robert, please post to .l10n before landing since this is a major change

Comment 28

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH