Closed Bug 345469 Opened 14 years ago Closed 13 years ago

port fix for bug #341697 (branding wizards) to sunbird

Categories

(Calendar :: Import and Export, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Sunbird 0.5

People

(Reporter: moco, Assigned: mattwillis)

Details

Attachments

(2 files)

port fix for bug #341697 (branding wizards) to sunbird

add new icon48.png for sunbird, fix the jar.mn, and then use branded=true where desired.

I'll attach the icon48.png for sunbird
Comment on attachment 230130 [details]
icon

r1=lilmatt
Attachment #230130 - Flags: second-review?(mvl)
Attachment #230130 - Flags: first-review+
Can somebody explain what this bug is trying to fix? bug 341697 is too long to read, and is also a spun-off without much explanation.
Wizards can now specify that they should have a branding image on top so an app supplied image is shown in the header of the wizard
 <wizard id="migrationWizard"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
...
+        branded="true"

https://bugzilla.mozilla.org/attachment.cgi?id=230132

This bug is for the Sunbird branding image 
The original problem here, I believe, was that the Firefox migration wizard, the first thing a user saw after installing, was not clearly delineated as belonging to Firefox.  To give that wizard branding, all wizards were modified to be able to include branding.  Seth may want to correct me here.
joey and robert are correct.

"To give that wizard branding, all wizards were modified to be able to include branding."

yes, but that was a bad move, and now you need to add branded="true" (as robert points out)

you'll need to make it your version of this icon is at chrome://branding/content/icon48.png, so that the css changes to toolkit will work for you.

Comment on attachment 230130 [details]
icon

r2=mvl
Attachment #230130 - Flags: second-review?(mvl) → second-review+
This puts the image where it needs to go in the jar.

Note that we'd check in the Sunbird 48px icon in other-licenses, and a 48px version of the generic calendar in calendar/sunbird/base/branding.
Assignee: nobody → lilmatt
Status: NEW → ASSIGNED
Attachment #244279 - Flags: first-review?(mvl)
Severity: normal → enhancement
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [patch in hand][needs review mvl]
Target Milestone: --- → Sunbird 0.5
Comment on attachment 244279 [details] [diff] [review]
Adds icon48.png to calendar.jar

r=mvl
Attachment #244279 - Flags: first-review?(mvl) → first-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs review mvl]
You need to log in before you can comment on or make changes to this bug.