345469 - port fix for bug #341697 (branding wizards) to sunbird

Status: RESOLVED FIXED

(Calendar :: Import and Export, enhancement)

Description

[(not reading, please use [e-mail] instead)]

port fix for bug #341697 (branding wizards) to sunbird

add new icon48.png for sunbird, fix the jar.mn, and then use branded=true where desired.

I'll attach the icon48.png for sunbird

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: icon

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 230130 [details]
icon

r1=lilmatt

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Can somebody explain what this bug is trying to fix? bug 341697 is too long to read, and is also a spun-off without much explanation.

Comment 4

[Robert Strong (they/them - no direct email)]

Wizards can now specify that they should have a branding image on top so an app supplied image is shown in the header of the wizard
 <wizard id="migrationWizard"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
...
+        branded="true"

https://bugzilla.mozilla.org/attachment.cgi?id=230132

This bug is for the Sunbird branding image 

Comment 5

[Joey Minta]

The original problem here, I believe, was that the Firefox migration wizard, the first thing a user saw after installing, was not clearly delineated as belonging to Firefox.  To give that wizard branding, all wizards were modified to be able to include branding.  Seth may want to correct me here.

Comment 6

[(not reading, please use [e-mail] instead)]

joey and robert are correct.

"To give that wizard branding, all wizards were modified to be able to include branding."

yes, but that was a bad move, and now you need to add branded="true" (as robert points out)

you'll need to make it your version of this icon is at chrome://branding/content/icon48.png, so that the css changes to toolkit will work for you.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 230130 [details]
icon

r2=mvl

Comment 8

[Matthew (lilmatt) Willis]

Attachment: Adds icon48.png to calendar.jar

This puts the image where it needs to go in the jar.

Note that we'd check in the Sunbird 48px icon in other-licenses, and a 48px version of the generic calendar in calendar/sunbird/base/branding.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 244279 [details] [diff] [review]
Adds icon48.png to calendar.jar

r=mvl

Comment 10

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED