Closed Bug 345600 Opened 15 years ago Closed 15 years ago

Crash [@ nsTextInputListener::UpdateTextInputCommands] using onselect and removing textarea

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: martijn.martijn, Assigned: smaug)

References

Details

(Keywords: crash, fixed1.8.1, testcase)

Crash Data

Attachments

(2 files)

See upcoming testcase, when selecting something in the textarea, Mozilla crashes.
This is not a (recent) regression, Mozilla1.7 also crashes.

Talkback ID: TB21243745K
nsTextInputListener::UpdateTextInputCommands   nsTextInputListener::NotifySelectionChanged   nsTypedSelection::NotifySelectionListeners   nsFrameSelection::NotifySelectionListeners   nsFrame::HandleEvent   nsPresShellEventCB::HandleEvent   nsEventDispatcher::Dispatch   PresShell::HandleEventInternal   PresShell::HandlePositionedEvent   PresShell::HandleEvent   nsViewManager::HandleEvent   nsViewManager::DispatchEvent   HandleEvent   nsWindow::DispatchEvent   nsWindow::DispatchMouseEvent
Attached file testcase
Simple null check is not enough, but propagating error up helps.
(Trunk patch would look almost the same, I just happened to have up-to-date 1.8 
on this laptop.)
Assignee: events → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #230286 - Flags: superreview?(roc)
Attachment #230286 - Flags: review?(roc)
Attachment #230286 - Flags: superreview?(roc)
Attachment #230286 - Flags: superreview+
Attachment #230286 - Flags: review?(roc)
Attachment #230286 - Flags: review+
Good thing is that null check is enough on trunk.
I checked in the null check to trunk. I hope that is ok.
But do we want to get the fix to 1.8 too? I guess yes.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #230286 - Flags: approval1.8.1?
Whiteboard: [baking until 07-28]
Crash is Verified FIXED using build 2006-07-27-09 of SeaMonkey trunk under Windows XP with https://bugzilla.mozilla.org/attachment.cgi?id=230278&action=view as the testcase.
Status: RESOLVED → VERIFIED
Comment on attachment 230286 [details] [diff] [review]
proposed patch (for 1.8)

approved by schrep for drivers
Attachment #230286 - Flags: approval1.8.1? → approval1.8.1+
Keywords: fixed1.8.1
Whiteboard: [baking until 07-28]
Depends on: 346964
Crash Signature: [@ nsTextInputListener::UpdateTextInputCommands]
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.