346964 - Component return failure code for nsISelection.getRangeAt

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Tommy Wu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060801 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060801 BonEcho/2.0b1

Some operation in TinyMCE will get 'Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) or 0x80004005 (NS_ERROR_FAILURE) [nsISelection.getRangeAt]' error in error console, and the function is not work like before.

Reproducible: Always

Steps to Reproduce:
1.go to the TinyMCE example URL.
2.Move cursor to last char of last time (after the word Google)
3.press 'Enter' key. 
4.click 'Insert Date' button.
5.click 'Insert time' button.

Actual Results:  
step 3, get 2 error in error console, 1 for 0x80004005, 1 for 0x80070057
step 4, no date string add to the editor, and get 3 error for 0x80070057.
step 5, no time string add to the editor, and get 3 error for 0x80070057.


Expected Results:  
step 3, cursor should move to next line without any error.
step 4, append current date string to editor.
step 5. append current time string to editor.

build 2006073007 or before work without any problem for this.
build 2006073104 and 2006080116 will get the error.

Comment 1

[Steve England [:stevee]]

Regression range from comment 0

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-07-30+06%3A00%3A00&maxdate=2006-07-31+05%3A00%3A00&cvsroot=%2Fcvsroot

Comment 2

[Adam Guthrie]

Looks like fallout from bug 345600, then. Would be nice if we could get a minimized testcase for this.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I'm looking at this.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

This is just on 1.8.1.
On trunk bug 345600 was easier to fix, there wasn't need to propagate the error 
because of the changes how selection is handled and changes in 
nsFrame::HandleRelease (which were done in bug 336592).

The best way to fix this would be to fix bug 336592 also on branch (which is 
perhaps needed because of bug 346431), but the simple fix would be to propagate 
some special error value from nsTextInputListener::UpdateTextInputCommands and 
return the error code in nsTypedSelection::NotifySelectionListeners only if
thisListener->NotifySelectionChanged returns that special value.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I agree we should have 336592 on branch.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Minusing for blocking1.8.1, but we'll consider a patch.  Renominate if you can be more convincing about why we need to block on this.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

This should be fixed in 1.8.1 20060805 builds