Closed
Bug 345657
Opened 19 years ago
Closed 18 years ago
Syncronize cmd= and cmd+
Categories
(Camino Graveyard :: Toolbars & Menus, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.5
People
(Reporter: froodian, Assigned: froodian)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.13 KB,
patch
|
Details | Diff | Splinter Review |
Right now both cmd= and cmd+ make text bigger, but they aren't validated the same way. For instance:
1. Load about:blank
2. cmd= (beeps)
3. cmd+ (makes "text" bigger)
4. load another page
What happens: text is bigger.
|
Assignee | |
Comment 1•19 years ago
|
||
Synchronizes to match what cmd='s validation requirements will be once bug 327966 lands.
Attachment #230365 -
Flags: review?(stuart.morgan)
|
||
Comment 2•18 years ago
|
||
Why not move this logic to a BWC method, rather than keeping it around in 3 places (almost guaranteeing that it will get out of sync again at some point)?
|
|
Assignee | |
Comment 3•18 years ago
|
||
(In reply to comment #2)
> Why not move this logic to a BWC method, rather than keeping it around in 3
> places (almost guaranteeing that it will get out of sync again at some point)?
>
Sigh. Because I'll bitrot my default text size patch, of course! ;)
Attachment #230365 -
Attachment is obsolete: true
Attachment #231007 -
Flags: review?(stuart.morgan)
Attachment #230365 -
Flags: review?(stuart.morgan)
|
|
Assignee | |
Comment 4•18 years ago
|
||
Comment on attachment 231007 [details] [diff] [review]
Moves logic to BWC methods
The fix for this is in bug 181712
Attachment #231007 -
Flags: review?(stuart.morgan)
Fixing up the deps; the latest version of that patch still has this fix, right?
Depends on: 181712
|
|
Assignee | |
Comment 6•18 years ago
|
||
Yes.
|
|
Assignee | |
Comment 7•18 years ago
|
||
Fixed by bug 181712
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•