The default bug view has changed. See this FAQ.

Syncronize cmd= and cmd+

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Toolbars & Menus
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: froodian (Ian Leue), Assigned: froodian (Ian Leue))

Tracking

Trunk
Camino1.5
PowerPC
Mac OS X

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Right now both cmd= and cmd+ make text bigger, but they aren't validated the same way.  For instance:

1. Load about:blank
2. cmd= (beeps)
3. cmd+ (makes "text" bigger)
4. load another page

What happens: text is bigger.
(Assignee)

Comment 1

11 years ago
Created attachment 230365 [details] [diff] [review]
Patch

Synchronizes to match what cmd='s validation requirements will be once bug 327966 lands.
Attachment #230365 - Flags: review?(stuart.morgan)

Comment 2

11 years ago
Why not move this logic to a BWC method, rather than keeping it around in 3 places (almost guaranteeing that it will get out of sync again at some point)?
(Assignee)

Comment 3

11 years ago
Created attachment 231007 [details] [diff] [review]
Moves logic to BWC methods

(In reply to comment #2)
> Why not move this logic to a BWC method, rather than keeping it around in 3
> places (almost guaranteeing that it will get out of sync again at some point)?
> 

Sigh.  Because I'll bitrot my default text size patch, of course! ;)
Attachment #230365 - Attachment is obsolete: true
Attachment #231007 - Flags: review?(stuart.morgan)
Attachment #230365 - Flags: review?(stuart.morgan)
(Assignee)

Comment 4

11 years ago
Comment on attachment 231007 [details] [diff] [review]
Moves logic to BWC methods

The fix for this is in bug 181712
Attachment #231007 - Flags: review?(stuart.morgan)
Fixing up the deps; the latest version of that patch still has this fix, right?
Depends on: 181712
(Assignee)

Comment 6

11 years ago
Yes.
(Assignee)

Comment 7

11 years ago
Fixed by bug 181712
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.