Ability to save column list in saved searches

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
Query/Bug List
P2
enhancement
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Enrico Weigelt, Assigned: Ronaldo Maia)

Tracking

2.22
Bugzilla 3.2
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060719
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060719


View of stored seaches should be customizable, so can ie. define Fields to be displayed there too.


Reproducible: Always

Comment 1

11 years ago
Could you describe in a little more detail what you'd like?
(Reporter)

Comment 2

11 years ago
I'd like to be able to store also the fields to show, sort order, etc. with the search. For example if I search for bugs in some certain product, I obviously don't need the product name in the output.

Comment 3

11 years ago
So Saved Searches don't currently save the columnlist parameter?
OS: Linux → All
Hardware: PC → All
Summary: Feature Request: customizable search view → Ability to save column list in saved searches
Version: unspecified → 2.22
(Reporter)

Comment 4

11 years ago
No, no that I no, do they ?

Comment 5

11 years ago
I am running into this, and it some kind of bug, maybe a design bug.

If I save the URL from a previous buglist, with columnlist set, bugzilla sucks it in, and ignores it. The new url that shows up has the columnlist changed.

This is on Bugzilla 2.22.

Comment 6

10 years ago
Created attachment 257617 [details] [diff] [review]
v1

Hey LpSolit--this is romaia's patch--you've actually already reviewed it once. :-)

Do you think it needs any changes in order to go upstream? I like it pretty well.
Assignee: query-and-buglist → mkanat
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #257617 - Flags: review?(LpSolit)

Updated

10 years ago
Target Milestone: --- → Bugzilla 3.2

Updated

10 years ago
Priority: -- → P2

Comment 7

10 years ago
Comment on attachment 257617 [details] [diff] [review]
v1

Should maybe some of the colchange.cgi parts be less hackish? That is, are there some security things that could be moved into Search::Saved?

Comment 8

10 years ago
Comment on attachment 257617 [details] [diff] [review]
v1

>=== modified file 'colchange.cgi'

>+    if ($cgi->param('save_columns_for_search') &&
>+        defined $search && $search->user->id == Bugzilla->user->id) {

Nit: use Bugzilla's style here, i.e.:

  if ($long_line_1
      && $long_line_2)
  {

I didn't complain on b.e.c because this was a very minor thing. ;)



>=== modified file 'template/en/default/list/change-columns.html.tmpl'

>+  [% IF saved_search %]
>+  <p>

Nit: please fix the indentation.


>+    <input type="checkbox" id="save_columns_for_search" checked="checked" 

Just one comment: note that the checkbox is crossed by default, which is a different behavior compared to what we have currently. But I think that's fine and is probably the right default (especially because this will only affects existing saved searches).

All my other comments have already been addressed in this patch, so r=LpSolit.


Note to the one doing the checkin: the author of the patch is romaia!
Attachment #257617 - Flags: review?(LpSolit) → review+

Comment 9

10 years ago
Reassigning to the original patch's author -> romaia.
Assignee: mkanat → romaia
Status: ASSIGNED → NEW
Flags: approval+

Comment 10

10 years ago
Thanks to Adobe for sponsoring this work, by the way.

Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.59; previous revision: 1.58
done
Checking in template/en/default/list/change-columns.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/change-columns.html.tmpl,v  <--  change-columns.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: relnote
Resolution: --- → FIXED

Updated

10 years ago
Duplicate of this bug: 105110

Updated

10 years ago
Duplicate of this bug: 403573

Comment 13

9 years ago
Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.
Keywords: relnote

Updated

9 years ago
Blocks: 443479
You need to log in before you can comment on or make changes to this bug.