Closed
Bug 346054
Opened 19 years ago
Closed 19 years ago
Crash when removing <tooltip> before showing it
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
VERIFIED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
(4 keywords)
Attachments
(3 files, 1 obsolete file)
|
519 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
|
1018 bytes,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
2.00 KB,
patch
|
roc
:
review+
roc
:
superreview+
dveditz
:
approval1.8.0.7+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
testcase and a simple patch coming.
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Comment 2•19 years ago
|
||
I noticed this crash while I was trying to reproduce Bug 184363 (still haven't
seen that crash).
I know menu/popup handling should be quite different, but because it is still
modifying content in layout, better to make it not crash so easily.
Attachment #230855 -
Flags: superreview?(roc)
Attachment #230855 -
Flags: review?(roc)
|
|
Assignee | |
Comment 3•19 years ago
|
||
Attachment #230855 -
Attachment is obsolete: true
Attachment #230859 -
Flags: superreview?(roc)
Attachment #230859 -
Flags: review?(roc)
Attachment #230855 -
Flags: superreview?(roc)
Attachment #230855 -
Flags: review?(roc)
|
||
Updated•19 years ago
|
Attachment #230859 -
Flags: superreview?(roc)
Attachment #230859 -
Flags: superreview+
Attachment #230859 -
Flags: review?(roc)
Attachment #230859 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 4•19 years ago
|
||
I'll write a new patch, so that bug 346424 doesn't happen.
|
|
Assignee | |
Comment 5•19 years ago
|
||
And because the patch in bug 343457 is also in 1.8, this should be there too.
Depends on: 343457
Flags: blocking1.8.1?
|
|
Assignee | |
Comment 6•19 years ago
|
||
This doesn't regress bug 343457 or bug 346424.
Ugly, but should be safe.
Attachment #231572 -
Flags: superreview?(roc)
Attachment #231572 -
Flags: review?(roc)
Flags: blocking1.8.1? → blocking1.8.1+
Attachment #231572 -
Flags: superreview?(roc)
Attachment #231572 -
Flags: superreview+
Attachment #231572 -
Flags: review?(roc)
Attachment #231572 -
Flags: review+
|
|
Assignee | |
Comment 7•19 years ago
|
||
Will ask approval for 1.8 soon.
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Attachment #231572 -
Flags: approval1.8.1?
|
||
Comment 8•19 years ago
|
||
Comment on attachment 231572 [details] [diff] [review]
better patch
a=schrep for drivers.
Attachment #231572 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Assignee | |
Updated•19 years ago
|
Keywords: fixed1.8.1
|
|
Assignee | |
Comment 9•19 years ago
|
||
Since bug 343457 is blocking 1.8.0.7, this should too.
Flags: blocking1.8.0.7?
|
|
Assignee | |
Comment 10•19 years ago
|
||
Attachment #231572 -
Flags: approval1.8.0.7?
|
||
Comment 11•19 years ago
|
||
Comment on attachment 231572 [details] [diff] [review]
better patch
approved for 1.8.0 branch, a=dveditz for drivers
Attachment #231572 -
Flags: approval1.8.0.7? → approval1.8.0.7+
|
|
||
Updated•19 years ago
|
Flags: blocking1.8.0.7? → blocking1.8.0.7+
|
|
Assignee | |
Updated•19 years ago
|
Keywords: fixed1.8.0.7
|
||
Comment 12•19 years ago
|
||
Verified FIXED using 1.8 and 1.8.0 on Linux (X11; U; Linux i686; en-US;). For what it's worth, attachment 230854 [details] didn't crash 1.5.0.6 even before this patch went in.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•