346082 - Remove aDragSession.sourceNode check from onDragExit method in tabbrowser.xml

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[Wayne Woods]

This is a follow-up from bug 333791 comment 53. Now that bug 345425 is fixed, there's no danger of aDragSession.sourceNode being null in onDragExit. So we can remove the check for it. Patch follows.

Comment 1

[Wayne Woods]

Attachment: Removes the aDragSession.sourceNode check, and also tidies up a few crooked indents

The actual important bit is right at the end of the patch. The rest are just a few bad indents in the code that I wanted to correct at the same time because I'm anal and because they disrupt my flow of reading... but mostly just because I'm anal. I hope it's ok.

Comment 2

[Wayne Woods]

Would also be nice to land on the 1.8 branch, but not critical.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 230882 [details] [diff] [review]
Removes the aDragSession.sourceNode check, and also tidies up a few crooked indents

r=sspitzer for the trunk, assuming you've tested and made sure that aDragSession.sourceNode is no longer null on the mac.

Comment 4

[Wayne Woods]

OK, cancel that. In light of bug 346172, I checked what happens when I drag links from mail messages over the tabs. In that situation, onDragExit is also called with a null aDragSession.sourceNode.

So we can't remove the check. -> WONTFIX

I didn't think that part of the tab dnd code was executed when other components are doing the drag. Sorry.