Closed Bug 346172 Opened 19 years ago Closed 19 years ago

dragging a link into firefox and dropping it onto a tab opens it in the focused tab, and not the desired tab

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: moco, Assigned: moco)

References

Details

(Keywords: fixed1.8.1, regression)

Attachments

(1 file)

fix
1.11 KB, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review
dragging a link into firefox and dropping it onto a tab opens it in the focused tab, and not the desired tab david writes: "I'm running a release build on windows, obviously and dragging the link from a mail message down to the windows dock to bring ff forward and then onto the tab in the tab bar which I've been doing for a long time today's the first day it started opening the link in the wrong tab" On my console I see: JavaScript error: chrome://global/content/bindings/tabbrowser.xml, line 1668: aD ragSession.sourceNode has no properties
Status: NEW → ASSIGNED
appears to be from bug #333791
Depends on: 333791
here's the problem: + <method name="canDrop"> + <parameter name="aEvent"/> + <parameter name="aDragSession"/> + <body> + <![CDATA[ + if (aDragSession.sourceNode.parentNode == this.mTabContainer && we need to check that aDragSession.sourceNode is not null. patch coming...
Attached patch fix — — Splinter Review
Attachment #230993 - Flags: review?(mconnor)
Attachment #230993 - Flags: approval1.8.1?
Flags: blocking-firefox2?
Attachment #230993 - Flags: review?(mconnor) → review+
*** Bug 346006 has been marked as a duplicate of this bug. ***
fixed on the trunk. seeking approval for branch.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [fixed on trunk][seeking approval for the branch]
Ugh. Thanks for catching this, Seth.
Flags: blocking-firefox2? → blocking-firefox2+
Attachment #230993 - Flags: approval1.8.1? → approval1.8.1+
fixed on branch as well.
Keywords: fixed1.8.1
Whiteboard: [fixed on trunk][seeking approval for the branch]
Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007111304 Minefield/3.0b2pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: