346111 - [10.4] javascript:alert() typed in location bar doesn't close if loaded from autocomplete drop-down

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Percy]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.4) Gecko/20060613 Camino/1.0.2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.4) Gecko/20060613 Camino/1.0.2

When loading a javascript:alert() URL from the history drop-down list, the alert window does not close.

Reproducible: Always

Steps to Reproduce:
1. Type in a javascript:alert() such as javascript:alert('Hello'); in the location bar.
2. Close the alert() window.
3. Go back to the location bar and start typing in "javascript...", then select the full "javascript:alert('hello');" from the drop-down, and hit enter.
4. Try to close the alert() window...
Actual Results:  
Cannot close alert() window produced by selecting a alert() from the drop-down.

Expected Results:  
alert() window would close as it did the first time you typed in the javascript: URL.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This WFM on 10.3.9 with the latest branch nightly.

Comment 2

[Stuart Morgan]

I can confirm this; 10.4.7, 2006-06-24 branch.  Console shows:
Camino[9706] Exception caught in safeRunModalForWindow:relativeToWindow: NSImageCell's object value must be an NSImage.
when it happens.

Comment 3

[Stuart Morgan]

For whatever reason, the autocomplete list is still trying to be drawn after the results have been cleared.  -[AutoCompleteDataSource resultString:column:] is being called for row 0, col "icon" when there are no rows, which is hitting

112   NSString* result = @"";
113   
114   if (!mResults)
115     return result;

Obviously, @"" makes for a bad icon.

Comment 4

[Maximilian Ruderburg [:max] (Arctic Revolution)]

I can't reproduce this on PPC, only Intel. Stuart, can you confirm that?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Putting this on the 1.1 list, as it seems potentially serious (esp. if bug 351008 is related).

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

mento, can you take a look at this (and possibly bug 351008), which seem like they're Intel-only.

Comment 7

[Stuart Morgan]

*** Bug 351008 has been marked as a duplicate of this bug. ***

Comment 8

[Stuart Morgan]

Taking; this will be easy to fix.

Comment 9

[Stuart Morgan]

Attachment: fix

Always return the right type for the icon column.

Comment 10

[Chris Lawson (gone)]

Comment on attachment 239801 [details] [diff] [review]
fix

Looks good.

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 239801 [details] [diff] [review]
fix

Bonus points if you rename 'aColumn' to 'aColumnIdentifier'.

Comment 12

[Stuart Morgan]

Attachment: fix with renaming

Version to check in.  For double-bonus points, it not only does the above but also renames the method, since having a method called "resultString:..." return icons is uncool.

Comment 13

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Given bug 354918 and the fact that this bug was originally reported against 1.0.x, and the evil bug 351008, nominating this for 1.0.4.

Comment 15

[froodian (Ian Leue)]

Checked in on 1.8.0branch for 1.0.4