346168 - No error message shown when uploaded file exceeds size limit

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Robert Kaiser]

I today tried to upload the German dictionary extension for Gecko-1.8.1-based products, which is really big (2.5 MB) actually.
Of course, not allowing such big files is one problem here, but it's clear that we need a limit *somewhere*.

What really looks like a bug to me though is that submitting that I ended in getting an empty page shown for additem.php?function=additem2 - i.e. the decorations (header/menu/footer) are shown, but no content at all. I would have expected to at least see and error message that says "Your extension is too big to be handled by AMO" or something like that.
Showing an empty page is quite unfriendly to "users"...

Comment 1

[Robert Kaiser]

I just accidentally clicked "Next>>" on additem.php?type=E and I got the same, empty page. I think we should at least display an error message that tells the user we found no file - or whatever we detect the error to be.

Comment 2

[Wil Clouser [:clouserw]]

Attachment: will show error if there is one

The status code errors were already there (albeit, they are somewhat cryptic).  If the status isn't 0, I just print the error and exit.

Comment 3

[Michael Morgan [:morgamic]]

Comment on attachment 231471 [details] [diff] [review]
will show error if there is one

Looks good -- checks out with:
http://php.osuosl.org/manual/en/features.file-upload.errors.php

And the FOOTER require is better than a die().

Comment 4

[Wil Clouser [:clouserw]]

Patch is in CVS.

Comment 5

[Cameron]

What is the limit at the moment? 

Someone with a fast connection want to upload something huge to verify this?