346205 - Return Receipts prefs shouldn't be under Composition

Status: NEW

(Thunderbird :: Preferences, defect)

Description

[Mikel Ward]

Tools->Composition->General has a button "Return Receipts..." with a label "Configure how Thunderbird handles return receipts.

I had to hunt for this one.  It's grouped under Composition, but has nothing to do with Composition.  It affects display of existing messages, not how new messages are written, thus it should instead be under the Display group.

Comment 1

[Mike Cowperthwaite]

I agree with this bug, but it doesn't impede functionality.  Reducing severity to minor, but maybe it should even be an enhancement.

Comment 2

[Mike Cowperthwaite]

Sorry, shouldn't have changed the component.

Comment 3

[Žiga Sancin]

Attachment: new return receipts tabpanel

Comment 4

[Žiga Sancin]

Attachment: move return receipts under display

Return receipts really shouldn't be under the composition group. The general tab of the composition group is also somewhat confusing (too many textfields, buttons and checkboxes...). We need Mikes!

Comment 5

[Mike Cowperthwaite]

When I said I agreed with this bug, I'd missed the point about about "it should instead be under the Display group."  No, it should not -- this is not a display function, it's an action.  What I agree with is that this feature isn't about Composition, either.

Of the existing top-level categories, the best fit for this tab seems to be Advanced -- it seems to me, Receipt handling is just as much an "advanced" feature as Offline.

Comment 6

[Scott MacGregor]

(In reply to comment #5)
> Of the existing top-level categories, the best fit for this tab seems to be
> Advanced -- it seems to me, Receipt handling is just as much an "advanced"
> feature as Offline.

I was thinking the same thing.

Comment 7

[Žiga Sancin]

Comment on attachment 233770 [details] [diff] [review]
move return receipts under display

Hum yes, good points. I thought about the advanced group first, but I wasn't sure about that - actually I thought it might be more discoverable under display (as the reporter suggests). 
However, there might be some problems with the "all other prefs" (advanced) group in the near future.

Comment 8

[Mikel Ward]

Actually, half of the Return Receipts preferences relate to sending mail (closest to Composition) and half relate to receiving mail (closest to Display).  Another option would be to break it in two and move the "When I receive a request for a return receipt:" and possibly the "When a receipt arrives:" option to the Display group.

Comment 9

[Žiga Sancin]

Attachment: patch

If you decide to move it under the advanced group...

Comment 10

[Scott MacGregor]

I like it here more, but I think we are out of access keys in the advanced options dialog! I think they are all taken. Not sure what to do about that. 

Comment 11

[Žiga Sancin]

Yes, we'll have to wait for bug 143065 and revisit this bug for Thunderbird 3.0 (or as soon as the patch from bug 143065 lands on the trunk).

Comment 12

[Mike Cowperthwaite]

Bug 361434 has addressed the basic part of this patch: Return Receipts are now found under Advanced|General -- but still in a single separate dialog rather than on one or two pages in the options.  This change is in the current nightly builds (patch checked in yesterday).

I'll leave it up to reporter whether that resolves the problem sufficiently.

Comment 13

[Mikel Ward]

Not a big fan of everything being under Advanced, but I like it more than the current situation.

Will download a nightly and see how it looks.

Comment 14

[Mikel Ward]

If it's going to be under Advanced, shouldn't it at least have its own tab rather than a button that launches a separate dialog?

Comment 15

[Ludovic Hirlimann [:Usul]]

(In reply to comment #11)
> Yes, we'll have to wait for bug 143065 and revisit this bug for Thunderbird 3.0
> (or as soon as the patch from bug 143065 lands on the trunk).

This has happened now (at least the bug is closed). You might ant to try to resubmit your patch.

Comment 16

[Žiga Sancin]

Comment on attachment 234327 [details] [diff] [review]
patch

The last patch is obsolete.

Comment 17

[Žiga Sancin]

cc'ing Bryan. He should make a final call about this bug and bug 361434.

Comment 18

[Bryan Clark (DevTools PM) [:clarkbw]]

we're trying to flatten out the preferences so we don't have so many tabs under each column; therefore i'm not really a fan of this layout change.

If we cleaned up the font issues, particularly bug 452711, then I would be comfortable moving the return receipts button (as it is now) from advanced into the display tab.  

also a side note, the "always request a return receipt" option definitely looks like a composition pref; likely it should be moved there.

Comment 19

[Javi Rueda :javirid]

Attachment: Proposal from comment 18

This screenshot shows the setting "When sending messages always request a return receipt" moved into Composition/General.

I don't request a UI review as a decission about this bug has not been got.

Comment 20

[Javi Rueda :javirid]

Attachment: Proposed and updated new Return receipts tab under Display

Although comment 18 is about moving the button into Display, I was unable to see any relationship between Fonts (the Formatting tab) and Tags, so I added a new tab to the Display section. This change was before proposed in attachment 233769 [details], but there it was another pane named "Fonts" which was merged with Formatting one.

So, This is pretty much the same content, but without the "Always request a return receipt" checkbox.