Yet another RFC 2231 violation (0x2a is not escaped)

VERIFIED FIXED

Status

MailNews Core
Composition
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

({fixed1.8.0.7, verified1.8.1})

Trunk
x86
Windows XP
fixed1.8.0.7, verified1.8.1
Bug Flags:
blocking-thunderbird2 +
blocking1.8.0.7 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
This bug is missed when fixing bug 338859.
0x2a should also be escaped. It will appear only if 7-bit a charset is used.
Patch is coming.
(Assignee)

Comment 1

11 years ago
Created attachment 231102 [details] [diff] [review]
Patch rv 1.0
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #231102 - Flags: superreview?(mscott)
Attachment #231102 - Flags: review?(mscott)
(Assignee)

Comment 2

11 years ago
Created attachment 231105 [details] [diff] [review]
Patch rv 1.1

Oops, I forgot that ':' could be used in filename on non-Windows platforms.
I'm planning to extend nsEscape to support RFC 2231, but it would not acceptable on branch (because it causes API change).
So I'll escape everything in this patch.
Attachment #231102 - Attachment is obsolete: true
Attachment #231105 - Flags: superreview?(mscott)
Attachment #231105 - Flags: review?(mscott)
Attachment #231102 - Flags: superreview?(mscott)
Attachment #231102 - Flags: review?(mscott)
(Assignee)

Comment 3

11 years ago
> ':' could be used in
'*' could be used in
Sorry for the typo.
This is a standard compliance problem. We should block next release.
Flags: blocking1.8.0.6?
Flags: blocking-thunderbird2?

Comment 5

11 years ago
Comment on attachment 231105 [details] [diff] [review]
Patch rv 1.1

I'll let Masayuki review this patch too.
Attachment #231105 - Flags: superreview?(mscott)
Attachment #231105 - Flags: superreview+
Attachment #231105 - Flags: review?(mscott)
Attachment #231105 - Flags: review?(masayuki)
Comment on attachment 231105 [details] [diff] [review]
Patch rv 1.1

I tested Tb to Tb and Tb to Becky2. I don't find the regression. r=masayuki.

Please wait to check-in. I'll do tonight, sorry.
# If somebody can do before me, please do it.
Attachment #231105 - Flags: review?(masayuki) → review+
checked-in to trunk, thank you Kimura-san.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Flags: blocking-thunderbird2? → blocking-thunderbird2+

Comment 8

11 years ago
Comment on attachment 231105 [details] [diff] [review]
Patch rv 1.1

approving for thunderbird 2 so this can land on the 1.8.1 branch.
Attachment #231105 - Flags: approval-thunderbird2+
checked-in to 1.8 branch too, thanks.
Keywords: fixed1.8.1
-> v. on trunk.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 11

11 years ago
Comment on attachment 231105 [details] [diff] [review]
Patch rv 1.1

We should fix standard conformance problem as soon as possible.
Illegal messages may survive in the archive for a long time.
Moreover, gnus (prior to 2006-06-20) didin't tolerate our violation.
Attachment #231105 - Flags: approval1.8.0.7?
-> v. on 1.8.1branch
Keywords: fixed1.8.1 → verified1.8.1
Comment on attachment 231105 [details] [diff] [review]
Patch rv 1.1

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #231105 - Flags: approval1.8.0.7? → approval1.8.0.7+
Not blocking 1.8.0.7, but we're happy taking the patch if you get it in.
Flags: blocking1.8.0.7? → blocking1.8.0.7-
checked-in to 1.8.0 branch.
Keywords: fixed1.8.0.7
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.