Closed
Bug 346302
Opened 18 years ago
Closed 18 years ago
Yet another RFC 2231 violation (0x2a is not escaped)
Categories
(MailNews Core :: Composition, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: emk, Assigned: emk)
Details
(Keywords: fixed1.8.0.7, verified1.8.1)
Attachments
(1 file, 1 obsolete file)
|
1.99 KB,
patch
|
masayuki
:
review+
mscott
:
superreview+
mscott
:
approval-thunderbird2+
dveditz
:
approval1.8.0.7+
|
Details | Diff | Splinter Review |
This bug is missed when fixing bug 338859. 0x2a should also be escaped. It will appear only if 7-bit a charset is used. Patch is coming.
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #231102 -
Flags: superreview?(mscott)
Attachment #231102 -
Flags: review?(mscott)
|
|
Assignee | |
Comment 2•18 years ago
|
||
Oops, I forgot that ':' could be used in filename on non-Windows platforms. I'm planning to extend nsEscape to support RFC 2231, but it would not acceptable on branch (because it causes API change). So I'll escape everything in this patch.
Attachment #231102 -
Attachment is obsolete: true
Attachment #231105 -
Flags: superreview?(mscott)
Attachment #231105 -
Flags: review?(mscott)
Attachment #231102 -
Flags: superreview?(mscott)
Attachment #231102 -
Flags: review?(mscott)
|
|
Assignee | |
Comment 3•18 years ago
|
||
> ':' could be used in
'*' could be used in
Sorry for the typo.
|
||
Comment 4•18 years ago
|
||
This is a standard compliance problem. We should block next release.
Flags: blocking1.8.0.6?
Flags: blocking-thunderbird2?
|
||
Comment 5•18 years ago
|
||
Comment on attachment 231105 [details] [diff] [review] Patch rv 1.1 I'll let Masayuki review this patch too.
Attachment #231105 -
Flags: superreview?(mscott)
Attachment #231105 -
Flags: superreview+
Attachment #231105 -
Flags: review?(mscott)
Attachment #231105 -
Flags: review?(masayuki)
|
|
||
Comment 6•18 years ago
|
||
Comment on attachment 231105 [details] [diff] [review] Patch rv 1.1 I tested Tb to Tb and Tb to Becky2. I don't find the regression. r=masayuki. Please wait to check-in. I'll do tonight, sorry. # If somebody can do before me, please do it.
Attachment #231105 -
Flags: review?(masayuki) → review+
|
|
||
Comment 7•18 years ago
|
||
checked-in to trunk, thank you Kimura-san.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Updated•18 years ago
|
Flags: blocking-thunderbird2? → blocking-thunderbird2+
|
|
||
Comment 8•18 years ago
|
||
Comment on attachment 231105 [details] [diff] [review] Patch rv 1.1 approving for thunderbird 2 so this can land on the 1.8.1 branch.
Attachment #231105 -
Flags: approval-thunderbird2+
|
|
Assignee | |
Comment 11•18 years ago
|
||
Comment on attachment 231105 [details] [diff] [review] Patch rv 1.1 We should fix standard conformance problem as soon as possible. Illegal messages may survive in the archive for a long time. Moreover, gnus (prior to 2006-06-20) didin't tolerate our violation.
Attachment #231105 -
Flags: approval1.8.0.7?
|
||
Comment 13•18 years ago
|
||
Comment on attachment 231105 [details] [diff] [review] Patch rv 1.1 approved for 1.8.0 branch, a=dveditz for drivers
Attachment #231105 -
Flags: approval1.8.0.7? → approval1.8.0.7+
|
|
||
Comment 14•18 years ago
|
||
Not blocking 1.8.0.7, but we're happy taking the patch if you get it in.
Flags: blocking1.8.0.7? → blocking1.8.0.7-
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•