346317 - Browser goes into an endless loop after automatically subscribing to this feed

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Matthew Kairys]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1b1) Gecko/20060728 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1b1) Gecko/20060728 BonEcho/2.0b1

After loading a RSS feed (http://www.xml.com/2002/12/18/examples/rss20.xml.txt) the GUI loaded up as usual. If you select 'Change Reader...', select 'Use Live Bookmarks' and then select the option for the feeds to load up automatically, close the dialog window then refresh the page, the Add Live Bookmark dialog will appear blank and an endless supply of dialogs are created and Firefox must either be killed or closed (if possible). Also upon killing Firefox and using Session Restore, the program reoccurs immediately.  

Reproducible: Always

Steps to Reproduce:
1. Load RSS Feed in Address Bar
2. Select 'Change Reader...' in the GUI
3. Select 'Use Live Bookmarks' and select option to use chosen reader automatically
4. Reload RSS Feed
Actual Results:  
Firefox hangs and the Add Live Bookmark dialog is recreated endlessly. 

Expected Results:  
Add Live Bookmark dialog appears and is usable. 

Used a clean profile with no themes or extensions.

Comment 1

[Gregor Larson]

I started getting an endless loop/freeze after an automatic update today:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060729 BonEcho/2.0b1

It seems to happen after a few minutes of browsing, gmail etc.
It did not happen before today (I have been getting daily automatic updates).

Comment 2

[Gregor Larson]

Matthew,
   Did did you see this bug before the July 27 nightly?
   If not, theh I suspect this is a recent break, perhaps a DUP of
   346233 or 346308.

Comment 3

[Martijn Wargers (dead)]

This regressed on branch between 2006-07-24 and 2006-07-27.

Comment 4

[Martijn Wargers (dead)]

More precisely, this regressed between 2006-07-26 and 2006-07-27:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-07-26+05&maxdate=2006-07-27+07&cvsroot=%2Fcvsroot

Comment 5

[Martijn Wargers (dead)]

Commenting out this line:
   // webNavigation.reload(Ci.nsIWebNavigation.LOAD_FLAGS_NONE);
from FeedConverter.js fixes the bug for me, this code was added with the patch for bug 341407.

Comment 6

[Mike Schroepfer]

Ben - can you take a look?

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Looking...

Comment 8

[Robert Sayre]

I think the user interaction that gets us into this bug is basically flawed. Clicking on links like the one in comment #0 should never add a live bookmark somewhere that I can't easily notice. I suggest we require the feed preview for live bookmarks.

Comment 9

[Phil Ringnalda (:philor)]

Alternate way to get into the same state: click a link that redirects to a feed (say, in a bug report you are reading through Gmail): if you select "Always subscribe with a Live Bookmark" in Options/Feeds, then clicking http://www.google.com/url?sa=D&q=http://www.mozilla.org/news.rdf puts you in the same infinite dialog loop. 

Rob: it only adds it in a place you can't see if you're using trunk, and that's a Places bug, that it doesn't put up the Add Live Bookmark dialog.

Comment 10

[Robert Sayre]

Attachment: Keep the feed list around if MOZ_FEEDS is enabled

The feed icon has rollover issues, but that's unrelated to this patch.

Comment 11

[Robert Sayre]

Attachment: Keep the feed list around if MOZ_FEEDS is enabled

Comment 12

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 233077 [details] [diff] [review]
Keep the feed list around if MOZ_FEEDS is enabled

r=me

Comment 13

[Robert Sayre]

Checking in base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.678; previous revision: 1.677
done
Checking in base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.313; previous revision: 1.312
done
Checking in components/feeds/src/FeedConverter.js;
/cvsroot/mozilla/browser/components/feeds/src/FeedConverter.js,v  <--  FeedConverter.js
new revision: 1.15; previous revision: 1.14
done

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 233077 [details] [diff] [review]
Keep the feed list around if MOZ_FEEDS is enabled

a=drivers for MOZILLA_1_8_BRANCH

Comment 15

[Robert Sayre]

Checking in base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.183; previous revision: 1.479.2.182
done
Checking in base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.268.2.55; previous revision: 1.268.2.54
done
Checking in components/feeds/src/FeedConverter.js;
/cvsroot/mozilla/browser/components/feeds/src/FeedConverter.js,v  <--  FeedConverter.js
new revision: 1.1.2.16; previous revision: 1.1.2.15
done

Comment 16

[Carsten Book [:Tomcat]]

Verified using the "Testcases" from comment #0 and comment #9 with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b2) Gecko/20060829 BonEcho/2.0b2