346375 - Move the code that gets the initial $dbh into Bugzilla::DB

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

The code around:

# Check if we have access to the --DATABASE--

Should be moved into a subroutine in a module

Comment 1

[Max Kanat-Alexander]

Actually, it makes more sense to put it into Bugzilla::DB, where the other DB-related code already is.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, here's the code that does it.

while I wrote the code, I also fixed it up a lot. It turns out that we were throwing our "unfriendly" DB error message when we couldn't connect to the DB, which probably accounts for a lot of support questions on the list. We now throw the more "friendly" checksetup-specific error when we fail to connect.

And, of course, the code is a zillion times cleaner. :-)

Comment 3

[Max Kanat-Alexander]

I've tested all the code paths, and I'm the module owner. Requesting approval directly.

Comment 4

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.522; previous revision: 1.521
done
Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.66; previous revision: 1.65
done
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.80; previous revision: 1.79
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.11; previous revision: 1.10
done

Comment 5

[Olav Vitters]

*** Bug 344647 has been marked as a duplicate of this bug. ***