Closed
Bug 346417
Opened 18 years ago
Closed 18 years ago
RTL justify code is wrong in nsTextFrame
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: rtl)
Attachments
(1 file, 1 obsolete file)
1.45 KB,
patch
|
smontagu
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
The RTL justify code is wrong. We should need to reset justification counter after calculating the frame width in nsTextFrame::PaintTextSlowly. And also the param of GetTextDimensions in nsTextFrame::PaintTextSlowly has wrong. The aIsEndOfFrame should be PR_TRUE instead of iter.IsLast().
Assignee | ||
Comment 1•18 years ago
|
||
But I have a question. Cannot we get frame width from |mRect.width| instead of |GetTextDimensions|??
Attachment #231224 -
Flags: superreview?(roc)
Attachment #231224 -
Flags: review?(roc)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•18 years ago
|
||
I think that this is enough and better. But I'm not sure.
Attachment #231226 -
Flags: superreview?(roc)
Attachment #231226 -
Flags: review?(roc)
Comment on attachment 231226 [details] [diff] [review] Patch rv1.0 (alternative) I think this is correct, just check with smontagu
Attachment #231226 -
Flags: superreview?(roc)
Attachment #231226 -
Flags: superreview+
Attachment #231226 -
Flags: review?(smontagu)
Attachment #231226 -
Flags: review?(roc)
Comment 4•18 years ago
|
||
Comment on attachment 231226 [details] [diff] [review] Patch rv1.0 (alternative) Looks good to me.
Attachment #231226 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 5•18 years ago
|
||
checked-in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•18 years ago
|
Attachment #231224 -
Attachment is obsolete: true
Attachment #231224 -
Flags: superreview?(roc)
Attachment #231224 -
Flags: review?(roc)
Comment 6•16 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in
before you can comment on or make changes to this bug.
Description
•