324870 - RTL text moves when selecting in text with text-align: justify (Cairo builds)

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.
All the lines in the testcase should look identical (except for the parts that are selected).

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Other way around -- fixing 327184 should fix this as well.

Comment 3

[Brian Polidoro]

It appears from this test case:
https://bugzilla.mozilla.org/attachment.cgi?id=197187&action=view
that text doesn't get justified in cairo builds.

Comment 4

[Vincent Lefevre]

This also occurs under Linux: OS should be set to All.

Comment 5

[dolphinling]

*** Bug 323697 has been marked as a duplicate of this bug. ***

Comment 6

[Stuart Parmenter]

this is fixed on windows

Comment 7

[dolphinling]

Fixed on linux, too. Sometime between 06-19 and 06-26, but I don't feel like downloading more builds to check. 

A quick trip through bonsai shows a checkin
2006-06-21 07:13  Bug 327184 CSS property letter-spacing rendered incorrectly r=pavlov 

So I'd put my money on that.

Comment 8

[Adam Guthrie]

-> WORKSFORME since we don't know what fixed this.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> REOPEN.

This a large part is fixed by bug 327184. But some Linux environments, I have a report this bug.

Comment 10

[Niro]

Attachment: Testcase (Hebrew)

The original testcase (attachment 209763 [details]) seems OK to me, on Windows.
In this testcase, there are some Hebrew words and it still buggy.

Comment 11

[Ger Teunis]

(In reply to comment #10)
> The original testcase (attachment 209763 [details] [edit]) seems OK to me, on Windows.
> In this testcase, there are some Hebrew words and it still buggy.

I confirm, also selecting seem to go wrong.
I.e. select from the first letter to the 3rd line: selection seem to get inverted.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I confirmed the RTL problem on Linux too. I have an idea for fix it. I'll work on it.

Comment 13

[Justin Kerk]

(In reply to comment #11)
> I confirm, also selecting seem to go wrong.
> I.e. select from the first letter to the 3rd line: selection seem to get
> inverted.

The selection "inverting" is correct behavior for RTL characters as far as I can tell, the bug is that the text shifts around a few pixels this way and that as you change the selection.

Comment 14

[Niro]

The only problem I can see in the second testcase is that the text moves a bit when selecting the text.
The first letter in RTL languages is always at the right edge. 

Comment 15

[Ger Teunis]

(In reply to comment #13)
> The selection "inverting" is correct behavior for RTL characters as far as I
> can tell

Of course, I forgot that Hebrew is written from right to left. My bad. 

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Testcase (Hebrew#2)

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: test patch #1

This patch doesn't work fine. I think that we should align the RTL text to right edge of the text frame. But this patch cannot do it. I have no idea what is wrong...

Note that currently, we are drawing following process.

1. draw right segment to left segment.
   i.e., if there are following segment:
     [Hebrew non-selected(C)][Hebrew selected(B)][Hebrew non-selected(A)]
   we draw A -> B -> C.

2. fix the spacing left to right in each segment. the base position of the spacing is left side of the segment.

Comment 18

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I find a bug of RTL justification code in nsTextFrame. See bug 346417 But it is not all.

Comment 19

[christoph.reiter]

Attachment: testcase

found that today...I'm not shure if that has anything to do with this bug or if I sould open a new one.

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #19)
> Created an attachment (id=250175) [details]
> testcase
> 
> found that today...I'm not shure if that has anything to do with this bug or if
> I sould open a new one.
> 

if you use mac, see bug 361581

Comment 21

[christoph.reiter]

(In reply to comment #20)
> (In reply to comment #19)
> > Created an attachment (id=250175) [details] [details]
> > testcase
> > 
> > found that today...I'm not shure if that has anything to do with this bug or if
> > I sould open a new one.
> > 
> 
> if you use mac, see bug 361581
> 
i use linux, Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a2pre) Gecko/20070102 Minefield/3.0a2pre

The strange thing is that sometimes it goes away if you open new tabs and firefox needs to be reopened to reproduce it...

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

O.K. This bug is only opened for RTL text selection bug. Please file a new bug.

Comment 23

[christoph.reiter]

opened bug 365715

Comment 24

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> WFM

this should be fixed by new textframe.

Comment 25

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).