346468 - Bug 344085 changed behaviour of tree.view unacceptably

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[James Ross]

As a result of bug 344085, calling tree.view when there is nothing in the tree throws an exception (NS_ERROR_UNEXPECTED). It used to return null. This has broken things that expected to be able to check if (tree.view) and similar.

As usual, the causing bug is marked security-sensitive, so it's currently unclear why the change was made - if any thought to this bit of the change happened at all.

Comment 1

[[e-mail]]

Could you explain what you mean by an empty tree or write a test case?
I tried getting the view from a <tree/> and it returned null for me.

Comment 2

[James Ross]

Go to a ChatZilla view that isn't a channel, then do:

  /eval document.getElementById("user-list").view

I notice that in my older build, this returns [object TreeContentView], but current trunk throws the exception instead so it looks like the behaviour has worsened more than I thought.

Comment 3

[James Ross]

Note that I'm not entirely sure what the tree's state is since every time ChatZilla tries to change the view it gets this unexpected exception, so the tree could be completely uninitialised for all I know.

Comment 4

[Frank Wein [:mcsmurf]]

Also see Bug 346530, it seems SeaMonkey Download Manager has been broken by this change.

Comment 5

[[e-mail]]

*** Bug 346530 has been marked as a duplicate of this bug. ***

Comment 6

[[e-mail]]

Attachment: Proposed patch

I forgot that not all builders are views...

Comment 7

[walter]

(In reply to comment #6)
> Created an attachment (id=231326) [edit]
> Proposed patch
> 
> I forgot that not all builders are views...

This patch fixes a similar bug in TB Account Settings that
I emailed you about, thanks.

Comment 8

[Adam Guthrie]

*** Bug 346600 has been marked as a duplicate of this bug. ***

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 346756 has been marked as a duplicate of this bug. ***

Comment 10

[[e-mail]]

*** Bug 346809 has been marked as a duplicate of this bug. ***

Comment 11

[[e-mail]]

Fix checked in.

Comment 12

[Adam Guthrie]

Verified FIXED using Thunderbird version 3 alpha 1 (20060802). The account settings window is now functional again.