346483 - Fix up param-updating code in checksetup.pl to all be in a module.

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

I think I'm going to leave the param-updating code in Bugzilla::Config, but I'm going to rename the sub and I'm going to re-work how the various subs work, to make everything cleaner, and so that I can move all the param-updating details into Bugzilla::Config.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, I centralized them all inside of what used to be UpdateParams, and renamed it to update_params.

I also renamed WriteParams to write_params and gave it an argument.

Oh, also, you can now specify defaults for params in the "answers" file for checksetup, which should be relnoted.

Comment 2

[Max Kanat-Alexander]

This is essentially installation code. I do touch a few non-installation files, but only because I renamed a few functions. It's true that most of the code I touch is in Bugzilla::Config, but it's all installation-related code.

So I feel okay saying that I'm the module owner for all this, and requesting approval directly.

Comment 3

[Max Kanat-Alexander]

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.43; previous revision: 1.42
done
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.526; previous revision: 1.525
done
Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.77; previous revision: 1.76
done
Checking in editparams.cgi;
/cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v  <--  editparams.cgi
new revision: 1.40; previous revision: 1.39
done
Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.15; previous revision: 1.14
done
Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.67; previous revision: 1.66
done

Comment 4

[Max Kanat-Alexander]

Added to the release notes on bug 255155.

Comment 5

[Max Kanat-Alexander]

The correct bug number for those release notes is actually bug 349423.