Omnibus ad-blocking bug for August

RESOLVED FIXED

Status

defect
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: alqahira, Assigned: alqahira)

Tracking

({fixed1.8.1})

unspecified
PowerPC
macOS
Bug Flags:
camino1.0.4 +

Details

Attachments

(1 attachment)

Repository for ads that need blocking that you see during August; please test the 1 Aug 18branch or trunk build (or later) before adding an ad or site url.
(In reply to comment #4)
> http://www.yceml.net/0533/10395157-10.gif
> 
> http://photos1.blogger.com/blogger/6305/956/1600/oddica.gif
> 
> http://photos1.blogger.com/blogger/6305/956/1600/jp33_ad.png
> 
> http://www.shareasale.com/image/botton06.jpg
> 
> http://pa.penny-arcade.com/92757ce8ea6bb5eac47371148a8f18bdceb5dc0a//cable.jpg
> 

None of these are easily blockable from what I can see. The Blogger ones are especially unblockable given that someone just uploaded an ad to Blogger to get it displayed.

The Penny Arcade one might be blockable. There's some iframes in source that mention ads at http://www.penny-arcade.com/.
AFAICT, yceml.net is just another Commission Junction ad-server. We can safely block all content from that domain, I think.

cl
(In reply to comment #6)
> AFAICT, yceml.net is just another Commission Junction ad-server. We can safely
> block all content from that domain, I think.

Yeah, you're right.
http://www.the-leader.com/articles/2006/08/17/news/local01.txt

A couple ads on there are slipping through.

cl
(In reply to comment #9)
> http://www.the-leader.com/articles/2006/08/17/news/local01.txt
> 
> A couple ads on there are slipping through.

They are all coming from http://adsys.townnews.com/
Seen on sfgate.com: iframe with src coming from http://media.adrevolver.com
on various imdb.com pages: iframe name="kanoodleAd" src="http://i.imdb.com/3pads/kanoodle-name.html" 

on various yahoo.com pages: iframe src=http://adq.nextag.com/buyer/dyad/300x250s.jsp

on various sf.net pages: 
img src = http://m1.2mdn.net/1251057/us_104_200604_21_tomca t3_728x90v2_6_.gif (2mdn.net serves iframes and embeds, also)

This patch

* fixes all the ads mentioned in this bug, as far as I can tell (with the exception of the blogger non-ads)

* fixes the ads on http://www.guenstiger.de/gt/main.asp?kat=35 from bug 350554 (the only one on which I could see un-blocked ads)

* fixes the Gmail right-hand-side ads (the div had changed)

Simon, do you recall why we don't block "/banner/" url fragments?  What did it break?
Attachment #236503 - Flags: superreview?(sfraser_bugs)
Attachment #236503 - Flags: review?(bugzilla)
Comment on attachment 236503 [details] [diff] [review]
August omnibus patch

Looks good, but I didn't actually test it.

How would you test something like this, anyway? Do we have a list of "important" sites somewhere that we should run these patches through to ensure they aren't blocking real content?

cl
Attachment #236503 - Flags: review?(bugzilla) → review+
Mostly just making sure the rules are sane and don't appear overly-broad, although browsing with your regular sites is useful (which makes cl the wrong person to test ;), but I did check Gmail this time....

> Simon, do you recall why we don't block "/banner/" url fragments?  What did it
> break?

I think I just assumed that it was too broad, and might block legitimate content.
Attachment #236503 - Flags: superreview?(sfraser_bugs) → superreview+
Status: NEW → ASSIGNED
Whiteboard: [needs checkin]
Checked in on trunk and 1.8branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Nominating for 1.0.3 so that I don't forget to nominate this for 1.0.4 when we finally get that flag created :/

The September bug is bug 351124.
Flags: camino1.0.3?
Flags: camino1.0.3? → camino1.0.4?
1.8.0 fix is in bug 359557
Flags: camino1.0.4? → camino1.0.4+
You need to log in before you can comment on or make changes to this bug.