359557 - Omnibus ad-blocking bug for November

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Chris Lawson (gone)]

Filed on behalf of Smokey since he hasn't filed one yet and I have more ads to block :-p

The following HTML snippet is showing an ad on MacUpdate:

<td id='ad_gutter'>
<a href='http://affiliates.digitalriver.com/z/5643/CD73614/'><img src='http://affiliates.digitalriver.com/42/73614/5643' height='120' width='120' alt='Parallels Desktop for Mac' border='0'></a><p><script language='JavaScript' type='text/javascript'>
<!--
   if (!document.phpAds_used) document.phpAds_used = ',';
   phpAds_random = new String (Math.random()); phpAds_random = phpAds_random.substring(2,11);
   
   document.write ("<" + "script language='JavaScript' type='text/javascript' src='");
   document.write ("http://ads.macupdate.com/adjs.php?n=" + phpAds_random);
   document.write ("&amp;what=zone:2");
   document.write ("&amp;exclude=" + document.phpAds_used);
   if (document.referer)
      document.write ("&amp;referer=" + escape(document.referer));
   document.write ("'><" + "/script>");
//-->

</script><noscript><a href='http://ads.macupdate.com/adclick.php?n=a0b57c19'><img src='http://ads.macupdate.com/adview.php?what=zone:2&amp;n=a0b57c19' border='0' alt=''></a></noscript>
</td>

Comment 1

[Simon Fraser [no longer active]]

Need iframe[src*="ads-rm.looksmart.com"] (and maybe others) to block awful crap on http://www.findarticles.com/.

Comment 2

[Simon Fraser [no longer active]]

Need to block flash (and maybe other content) from content.ru4.com for sfgate.com.

Comment 3

[sairuh (rarely reading bugmail)]

sfgate.com displays another annoyance, iframes from http://http-2081.edge.ru4.com/

Comment 4

[philippe (part-time)]

Since you removed div[id^="ad_"], in bug 355073, I see more google ads popping up.
Example: articles on IHT, down the right column.
(http://www.iht.com/articles/2006/11/17/news/france.php)

I block them with 
div[id*="ad_google"]

So far, no side effects: Gmail works fine, searching on google.com/google.co.jp works correctly.

Comment 5

[sairuh (rarely reading bugmail)]

*.adjuggler.com is another source of Flash ads on MacNN.com, for example:

http://img1.adjuggler.com/banners/Client171439/1161805959544_728x90_macOffice_Holiday.swf?clickTAG=http://rotator.adjuggler.com:80/servlet/ajrotator/202931/0/cj?ajkey=V1199AE89A144B7CAFB44B7CAFBL202962L206337QK76321QQP0G001C

Comment 6

[sairuh (rarely reading bugmail)]

content*.kanoodle.com is another source of ads in iframes, eg, on http://www.tokyopop.com:

http://context3.kanoodle.com/cgi-bin/context.cgi?id=87748823&db=context&cgroup=gorilla728x90&format=mon12tif&newtarget=1

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Nov omnibus fixes

This fixes everything mentioned here (except comment 0, which is both hard to block cleanly and no longer present), bug 359625, and also updates my email address.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

December is bug 362330.

Comment 9

[froodian (Ian Leue)]

Chickened on 1.8branch and trunk.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We'll see how long this has been live when we go to do 1.0.4, but nominating so we don't forget.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Consolidated Omnibus Ad-Blocking for Camino 1.0.4

This is the consolidated patch for ad-blocking for 1.0.4 (this bug, bug 355073, bug 351124, and bug 346792).

Comment 12

[froodian (Ian Leue)]

Checked in on 180 for 1.0.4