346796 - Change descriptions for DOM Inspector and Talkback to match new NSIS descriptions

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Reed Loden [:reed]]

The descriptions for DOM Inspector and Talkback have changed in the NSIS installer, so we want to use the same descriptions in the extensions themselves.

For DOM Inspector, "Inspects resources used by web pages and extensions."
For Talkback, "Sends information about crashes to Mozilla."

I'll attach a patch in a bit.

Comment 1

[Robert Strong (they/them - no direct email)]

This only affects Firefox since Thunderbird and Sunbird only ship QFA and this page is not shown during a custom install when WFA is the only optional component in the installer.

Comment 2

[Robert Strong (they/them - no direct email)]

s/WFA/QFA/

Comment 3

[Reed Loden [:reed]]

(strings pulled from bug 333160)

Umm, it seems Talkback's install.rdf is in the private repo. I'll need somebody with access to the repo to change Talkback's description.

:rs -- This bug is for the change in the extensions' install.rdf file, not the NSIS installer. Please stop moving it. :P

Comment 4

[Reed Loden [:reed]]

Swapped to bug 346798 for NSIS description changes.

New Talkback description is "Sends information about program crashes to Mozilla."

Comment 5

[Reed Loden [:reed]]

Anybody with access to Talkback code, please see comment #3 but use the description in comment #4.

Comment 6

[Robert Strong (they/them - no direct email)]

Since you came up with the text go ahead and change the installer strings for it as well. Also, there is no dependency between fixing accessibility of the installer's components page and changing the strings. :P

Comment 7

[Reed Loden [:reed]]

Attachment: Change DOMi's description - v1

Change DOM Inspector's description to "Inspects resources used by web pages and extensions."

Comment 8

[timeless]

for the record, this is entirely wrong.

DOMI inspects Documents, not Resources (it does not inspect CSS, JS, Properties, DTDs, or even Resource Description Format files [RDF]) nor Pages (as the current description incorrectly states. Who ever heard of a XML or XUL page? XML, HTML, XUL documents all exist and web pages, but not even HTML pages).

And this description happens to preclude the application chrome itself, which is generally what it inspects when it helps extension developers develop their extensions. it generally does not inspect individual extensions. certainly if you inspect noscript or the beeroclock extension you're not inspecting the extension, you're inspecting the application.

Since people are going to ignore me anyway, I'm including for posterity or whatever my draft which will be ignored.

DOMI enables developers of web pages and extensions to inspect properties of their rendered documents and test changes to them.

I'm sorry about the word "rendered", beltzner complained about the word "live".

Unfortunately for me, my safari (1.3.2 v312.6) has "Show DOM Tree" and "Show Render Tree". Actually, afaik DOMI is capable of expressing the equivalent of what Safari has in show render tree.

Goals for a description:
1. it should indicate that it will help developers of web pages and extensions developer whatever they're developing
2. to some extent it should indicate what it actually can look at (which is document object models, how this is described is sort of left to the author's discretion as long as it doesn't violate any other constraint)

Nongoals for a description:
a. it should not imply that you can't inspect the "browser" or whatever application is hosting domi.
b. it should not imply that you can use it to inspect the contents of other running applications (e.g. windows explorer, internet explorer, safari) - note that some applications *can* do this, I have one called Microsoft Script Debugger, it's an out of process application which hooks other processes [something we'll want domi to do, but which it can't do today]
c. it should not imply that you can inspect file formats that domi can't handle. this is basically all file formats: css, jpg, gif, png, js, properties, rdf, xbl, dtd, ....
d. it should not imply that it can inspect resources. as with file formats, it doesn't and can't.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

mconnor and I just realized that since we're keeping DOMi as app-managed, it actually won't be upgraded to the larger set of web tools, but instead will be phased out when we get the better Web Tools extension (ah, to the glorious future!)

So. This means two things:

1. We can call it "DOM Inspector". (cue applause)
2. We can describe it as: "Inspects the structure and properties of a window and its contents."

I'm going with this naming because:
  - short & sweet, like we did with QFA
  - verb phrase that describes what it does, not who its for and why it's a pancea for all their woes
  - removes implications that timeless felt were evil

Let the flaming over this non-issue begin!

Comment 10

[Reed Loden [:reed]]

Attachment: Take two - v2

Use "Inspects the structure and properties of a window and its contents."

Comment 11

[Reed Loden [:reed]]

Comment on attachment 231659 [details] [diff] [review]
Take two - v2

Requesting a1.8.1. This just changes the description of the DOM Inspector extension.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 231659 [details] [diff] [review]
Take two - v2

a=drivers. Please land on the MOZILLA_1_8_BRANCH.

Comment 13

[Robert Helmer [:rhelmer]]

Attachment: install.rdf changes for talkback

Comment 14

[Reed Loden [:reed]]

Comment on attachment 231673 [details] [diff] [review]
install.rdf changes for talkback

r=reed, thanks!

Requesting a1.8.1 for this small em:description change for Talkback.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 231673 [details] [diff] [review]
install.rdf changes for talkback

a=drivers. Allons-y sur le MOZILLA_1_8_BRANCH.

Comment 16

[Robert Helmer [:rhelmer]]

Landed install.rdf patch on talkback trunk and branch.

Comment 17

[Matthew (lilmatt) Willis]

DOMi patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED