User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060801 BonEcho/2.0b1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060801 BonEcho/2.0b1 Help Section "Using Bon Echo" -> "Searching" contains old-look Search Bar image from Firefox 1.5.x.x. Reproducible: Always Steps to Reproduce: 1. Open Firefox help. 2. Select Using Bon Echo -> Searching Actual Results: Contains old-look Search Bar image Expected Results: Should contain new Search Bar image
We need either a new screenshot or remove it. Note that the UI isn't final yet.
Thanks, but that's only the current state. Bug 345407 will make further changes to the searchbar.
Created attachment 233967 [details] Firefox2 Search bar Since bug 345407 is fixed, this one is the final search-bar look
Requesting blocking to get this either on the radar and landed or off my radar.
Axel, why is this on your radar? Do we need new images for all the locales to properly capture the default search engine for each locale? Or is this a straight one-time image replacement
Any help change is on my radar, and for CJKT builds, we may want to use a Yahoo screenshot. All others should actually be fine with a google one.
This needs to be updated at http://www.mozilla.org/projects/firefox/help/1.1/searchbar.png This is a web-hosted image, and thus can be replaced after freeze.
(In reply to comment #8) > This is a web-hosted image, and thus can be replaced after freeze. Not quite; the image is (as its name might slightly indicate) used in Firefox 1.5 as well, so we should really change the URL so 1.5 builds don't start having a funky search bar image.
Created attachment 238368 [details] [diff] [review] patch v1: URL change Per comment 9, here's a patch that changes the URL to one which identifies the default search engine in the en-US locale (for en-US, that's searchbar-google.png). Other locales can leave this as is or change it to reflect their default search engine, as needed (i.e. we can create a searchbar-yahoo.png for CJKT builds).
Comment on attachment 238368 [details] [diff] [review] patch v1: URL change not the right fix, we're going to change the baseURL, we've already copied the content over, and will update that content before ship
Created attachment 238452 [details] [diff] [review] change the baseURL turns out, we only have a couple of images that we use (searchbar and urlbar) but its better and cleaner to do this anyway!
Should this be .org vs .com?
updated content is checked in, will be live soon.
(In reply to comment #13) > Should this be .org vs .com? > Not at this point, its not specific to branded builds, and the rest of the remote help content is there. We don't currently have a home for Help yet, when we do we can redirect tehre.
Comment on attachment 238452 [details] [diff] [review] change the baseURL a=schrep
new images are live, landed branch and trunk
Post to .l10n to alert localizers? For those locales that use en-US screenshots, this has late-l10n impact, for those locales that ship localized screenshots in ab-CD.jar, it must not. Thus we can't easily cover this change.