346922 - assertions should be fatal when running unit tests

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Since assertions mean that there's a bug somewhere, and unit tests should ensure that there are no bugs, assertions should be fatal so that they can easily be caught.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Dave Liebreich [:davel]]

Comment on attachment 231840 [details] [diff] [review]
patch

assuming XPCOM_DEBUG_BREAK is the right env var to set . . .

Have you run the netwerk and content tests with this patch?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

I did run the netwerk tests (compare bug 346939 which was exposed by that); I'll run the content tests before checking this in.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

make check from toplevel passed, checked in
Checking in test_all.sh;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/test_all.sh,v  <--  test_all.sh
new revision: 1.3; previous revision: 1.2
done