Closed Bug 346934 Opened 14 years ago Closed 13 years ago
Unify Sunbird/Lightning item creation/modification code
Sunbird and Lightning currently have different functions for creating new events (and tasks) and for editing events (and tasks). This required me to add extra if/else cases in calendar-views.js. We should reduce code-paths and testing by making both apps use the same function.
There were only a few small differences between the Lightning and Sunbird impls. Lightning's impl always defaulted to today, whereas Sunbird's relied on the selected day in the view. I chose to go with Sunbird's choice here. Also, Sunbird uses the selected calendar for the default choice in the dialog. This required a minor fork, since the functions for selecting calendars are split, but we'll handle one fork at a time.
Comment on attachment 231685 [details] [diff] [review] move Sunbird to calendar-item-editing + modifyEventWithDialog( ThisToDo ); Can we just not continue the extra spaces inside the parens? I know the line you're replacing had it, but I _so_ don't want to keep doing it... Other than that, r=lilmatt and a cookie for killing another gCalendarWindow... line
Attachment #231685 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 231685 [details] [diff] [review] move Sunbird to calendar-item-editing r2=mvl, hoping this patch still applies.
Attachment #231685 - Flags: second-review?(mvl) → second-review+
Patched checked in. The calendar-item-editing.js changes were done in a separate bug already. That was the only major conflict.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs review mvl]
You need to log in before you can comment on or make changes to this bug.