1) Open any URL. 2) Open a new tab with the Bookmarks Manager in it. 3) Switch to the other tab (with WWW content in it). 4) Cmd-D. 5) Wonder why the Bookmarks menu just flashed and nothing else happened. 6) Close the tab containing the Bookmarks Manager. 7) Repeat step 4 and marvel at the restored functionality. 8) Profit!!! I haven't checked branch yet but I'm fairly certain this worked at one point, so I'm labeling it a regression for now.
I broke this in bug 188679. Taking.
Created attachment 231900 [details] [diff] [review] Patch The problem here is that we were writing over the outparams with nil, even though they had useful information when coming from |bookmarkableTitle| (though they should be overwritten if it's not nil). Simply not writing over them if we don't find anything is more elegant than checking whether the results were nil in |bookmarkableTitle|, so that's what this does.
Comment on attachment 231900 [details] [diff] [review] Patch r-, per IRC discussions. The right place to bullet-proof this would be in code that will be ripped out to fix bug 302614, so just do that.
Created attachment 231911 [details] [diff] [review] Gets rid of check entirely Rips out mentioned code, and the method description (since it's now self-explanatory)
Comment on attachment 231911 [details] [diff] [review] Gets rid of check entirely (oops, missed the text field). You may as well remove curTitle and curURL, since they don't serve a purpose.
Created attachment 232278 [details] [diff] [review] Slims it down Yeah, I wasn't sure if assigning outparams directly was acceptable practice or not.
*** Bug 347801 has been marked as a duplicate of this bug. ***
Created attachment 233427 [details] [diff] [review] Super slims it down per irc, getting rid of the method entirely.
Putting this regression on the 1.1 list so it doesn't get lost (even though it'll hopefully be fixed soon).
Comment on attachment 233427 [details] [diff] [review] Super slims it down r=me
Comment on attachment 233427 [details] [diff] [review] Super slims it down sr=pink i heart fixing bugs by removing code.
Checked into trunk and MOZILLA_1_8_BRANCH