347228 - turn off server push when X-Moz header set to "microsummary"

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

buglist.cgi enables server push for browsers that support it (principally Mozilla-based browsers) to display a "please wait" message to the user.  But when Firefox sets the X-Moz header to "microsummary", it means the browser's microsummary service is initiating the request, and that service doesn't have any use for the "please wait" message, because it doesn't display anything to the user until after the request has been completed.

We should turn off server push when the X-Moz header is set to "microsummary".

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: implements check for relevant X-Moz header value

Here's the patch that does the deed.  Dave, can you review and also apply to b.m.o in the interim so folks can take advantage of Dietrich's bug list microsummary generator?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: also turns off setting of cookies

In addition to the server push issue, there's also the issue that cookies, particularly the BUGLIST cookie, shouldn't be set for microsummary loads, or else users will see strange behavior when they have a buglist microsummary and are also executing queries manually.

Here's a patch that turns off both server push and the setting of cookies for microsummary requests.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: test microsummary generator for Bugzilla trunk

Here's a microsummary generator that works against the Bugzilla trunk, which has reorganized the bug list HTML.  I've set the <pages> section to include any buglist.cgi page on either localhost or landfill, so you should be able to test it with both local and landfill-based trunk installations of Bugzilla.

Comment 4

[Frédéric Buclin]

Comment on attachment 232810 [details] [diff] [review]
patch v2: also turns off setting of cookies

>+my $agent = ($cgi->http('X-Moz') =~ /\bmicrosummary\b/);

This line should be:
my $agent = ($cgi->http('X-Moz') && $cgi->http('X-Moz') =~ /\bmicrosummary\b/);

else you get:
buglist.cgi: Use of uninitialized value in pattern match (m//) at /var/www/html/cvsbugzilla/buglist.cgi line 119.


r=LpSolit with this line fixed.

Comment 5

[Frédéric Buclin]

It would probably make sense to take it for 2.22 too.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v3: fixes issue raised in comment 4

Comment 7

[Frédéric Buclin]

myk forgot to mark the bug as fixed:

tip:

mozilla/webtools/bugzilla/buglist.cgi 1.343

2.22:

mozilla/webtools/bugzilla/buglist.cgi 1.325.2.3