347405 - go button disconnected from URL bar. URL bar too tall

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Asa Dotzler [:asa]]

The Go button is several pixels separated from the URL bar and the URL bar is too tall for the two to line up. This is mac only.

Comment 1

[Asa Dotzler [:asa]]

Attachment: go button detached

Comment 2

[Dave Townsend [:mossop]]

Similar to bug 347403 which is on windows, however the detachment doesnt occur there.

Comment 3

[Mike Connor [:mconnor]]

URL bar too tall is not the theme landing, it should have a fix soon (was approved for branch already)

Gavin, did you land the browser.xul change from the windows patch?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> Gavin, did you land the browser.xul change from the windows patch?

Yes.

Comment 5

[Peter Kasting]

Similar to bug 347400.

Comment 6

[Vladimir Lushnikov]

Linux is affected too

http://www.vladsharp.com/images/work/go_button.png
http://www.vladsharp.com/images/work/go_button_mouseover.png

Comment 7

[Peter Kasting]

(In reply to comment #6)
> Linux is affected too
> 
> http://www.vladsharp.com/images/work/go_button.png
> http://www.vladsharp.com/images/work/go_button_mouseover.png

Actually, that looks more like bug 347447 or bug 347470.

Comment 8

[Dietrich Ayala (:dietrich)]

Attachment: band-aid

band-aid fix, doesn't fix the root-cause of the gap.

Comment 9

[Dietrich Ayala (:dietrich)]

Attachment: fix

removes right margin on URL bar.

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 233401 [details] [diff] [review]
fix

r+a=me on the stopgap, Ryan is actually working on a more comprehensive patch for removing the Go/Search buttons.

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #10)
> (From update of attachment 233401 [details] [diff] [review] [edit])
> r+a=me on the stopgap, Ryan is actually working on a more comprehensive patch
> for removing the Go/Search buttons.

Maybe this is would be appropriate:

#urlbar {
  margin: 5px 4px 5px 4px;
}
#urlbar + #go-button {
  margin-left: -4px;
}

Comment 12

[Dão Gottwald [:dao]]

(In reply to comment #11)

Okay, I see that's what Dietrich tried first. I guess the only problem was that the negative margin was applied for both #go-button and #go-container?

Comment 13

[Pam Greene]

The current file is broken for RTL.  Patch and necessary image to follow immediately.

Comment 14

[Pam Greene]

Attachment: pinstripe Go button for RTL

Comment 15

[Pam Greene]

Attachment: Fix for RTL

Comment 16

[Mike Connor [:mconnor]]

Comment on attachment 233707 [details] [diff] [review]
Fix for RTL

I wasn't thinking about RTL at all, I didn't realize we'd already done that

Comment 17

[Pam Greene]

Landing RTL fix on branch.