Closed
Bug 347405
Opened 19 years ago
Closed 18 years ago
go button disconnected from URL bar. URL bar too tall
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: asa, Assigned: dietrich)
References
Details
(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])
Attachments
(4 files, 1 obsolete file)
5.99 KB,
image/png
|
Details | |
847 bytes,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
5.45 KB,
image/png
|
Details | |
2.63 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The Go button is several pixels separated from the URL bar and the URL bar is too tall for the two to line up. This is mac only.
Reporter | ||
Comment 1•19 years ago
|
||
Comment 2•19 years ago
|
||
Similar to bug 347403 which is on windows, however the detachment doesnt occur there.
Comment 3•19 years ago
|
||
URL bar too tall is not the theme landing, it should have a fix soon (was approved for branch already)
Gavin, did you land the browser.xul change from the windows patch?
Comment 4•19 years ago
|
||
(In reply to comment #3)
> Gavin, did you land the browser.xul change from the windows patch?
Yes.
Comment 5•19 years ago
|
||
Similar to bug 347400.
Updated•19 years ago
|
Flags: blocking-firefox2+
Whiteboard: [Fx2 theme change]
Comment 6•18 years ago
|
||
Comment 7•18 years ago
|
||
(In reply to comment #6)
> Linux is affected too
>
> http://www.vladsharp.com/images/work/go_button.png
> http://www.vladsharp.com/images/work/go_button_mouseover.png
Actually, that looks more like bug 347447 or bug 347470.
Updated•18 years ago
|
Assignee: mconnor → dietrich
Updated•18 years ago
|
Target Milestone: --- → Firefox 2 beta2
Assignee | ||
Comment 8•18 years ago
|
||
band-aid fix, doesn't fix the root-cause of the gap.
Assignee | ||
Comment 9•18 years ago
|
||
removes right margin on URL bar.
Attachment #233399 -
Attachment is obsolete: true
Attachment #233401 -
Flags: review?(mconnor)
Comment 10•18 years ago
|
||
Comment on attachment 233401 [details] [diff] [review]
fix
r+a=me on the stopgap, Ryan is actually working on a more comprehensive patch for removing the Go/Search buttons.
Attachment #233401 -
Flags: review?(mconnor)
Attachment #233401 -
Flags: review+
Attachment #233401 -
Flags: approval1.8.1+
Assignee | ||
Updated•18 years ago
|
Comment 11•18 years ago
|
||
(In reply to comment #10)
> (From update of attachment 233401 [details] [diff] [review] [edit])
> r+a=me on the stopgap, Ryan is actually working on a more comprehensive patch
> for removing the Go/Search buttons.
Maybe this is would be appropriate:
#urlbar {
margin: 5px 4px 5px 4px;
}
#urlbar + #go-button {
margin-left: -4px;
}
Comment 12•18 years ago
|
||
(In reply to comment #11)
Okay, I see that's what Dietrich tried first. I guess the only problem was that the negative margin was applied for both #go-button and #go-container?
Comment 13•18 years ago
|
||
The current file is broken for RTL. Patch and necessary image to follow immediately.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 14•18 years ago
|
||
Comment 15•18 years ago
|
||
Attachment #233707 -
Flags: review?(mconnor)
Attachment #233707 -
Flags: approval1.8.1?
Comment 16•18 years ago
|
||
Comment on attachment 233707 [details] [diff] [review]
Fix for RTL
I wasn't thinking about RTL at all, I didn't realize we'd already done that
Attachment #233707 -
Flags: review?(mconnor)
Attachment #233707 -
Flags: review+
Attachment #233707 -
Flags: approval1.8.1?
Attachment #233707 -
Flags: approval1.8.1+
Comment 17•18 years ago
|
||
Landing RTL fix on branch.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•