go button disconnected from URL bar. URL bar too tall

RESOLVED FIXED in Firefox 2 beta2

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: asa, Assigned: dietrich)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 beta2
PowerPC
Mac OS X
fixed1.8.1
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2 theme change])

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
The Go button is several pixels separated from the URL bar and the URL bar is too tall for the two to line up. This is mac only.
(Reporter)

Comment 1

12 years ago
Created attachment 232168 [details]
go button detached
Similar to bug 347403 which is on windows, however the detachment doesnt occur there.
URL bar too tall is not the theme landing, it should have a fix soon (was approved for branch already)

Gavin, did you land the browser.xul change from the windows patch?
(In reply to comment #3)
> Gavin, did you land the browser.xul change from the windows patch?

Yes.

Updated

12 years ago
Blocks: 347454

Comment 5

12 years ago
Similar to bug 347400.

Updated

11 years ago
Flags: blocking-firefox2+
Whiteboard: [Fx2 theme change]

Comment 6

11 years ago
Linux is affected too

http://www.vladsharp.com/images/work/go_button.png
http://www.vladsharp.com/images/work/go_button_mouseover.png

Comment 7

11 years ago
(In reply to comment #6)
> Linux is affected too
> 
> http://www.vladsharp.com/images/work/go_button.png
> http://www.vladsharp.com/images/work/go_button_mouseover.png

Actually, that looks more like bug 347447 or bug 347470.

Updated

11 years ago
Assignee: mconnor → dietrich

Updated

11 years ago
Target Milestone: --- → Firefox 2 beta2
(Assignee)

Comment 8

11 years ago
Created attachment 233399 [details] [diff] [review]
band-aid

band-aid fix, doesn't fix the root-cause of the gap.
(Assignee)

Comment 9

11 years ago
Created attachment 233401 [details] [diff] [review]
fix

removes right margin on URL bar.
Attachment #233399 - Attachment is obsolete: true
Attachment #233401 - Flags: review?(mconnor)
Comment on attachment 233401 [details] [diff] [review]
fix

r+a=me on the stopgap, Ryan is actually working on a more comprehensive patch for removing the Go/Search buttons.
Attachment #233401 - Flags: review?(mconnor)
Attachment #233401 - Flags: review+
Attachment #233401 - Flags: approval1.8.1+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
(In reply to comment #10)
> (From update of attachment 233401 [details] [diff] [review] [edit])
> r+a=me on the stopgap, Ryan is actually working on a more comprehensive patch
> for removing the Go/Search buttons.

Maybe this is would be appropriate:

#urlbar {
  margin: 5px 4px 5px 4px;
}
#urlbar + #go-button {
  margin-left: -4px;
}
(In reply to comment #11)

Okay, I see that's what Dietrich tried first. I guess the only problem was that the negative margin was applied for both #go-button and #go-container?

Comment 13

11 years ago
The current file is broken for RTL.  Patch and necessary image to follow immediately.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 14

11 years ago
Created attachment 233706 [details]
pinstripe Go button for RTL

Comment 15

11 years ago
Created attachment 233707 [details] [diff] [review]
Fix for RTL
Attachment #233707 - Flags: review?(mconnor)
Attachment #233707 - Flags: approval1.8.1?
Comment on attachment 233707 [details] [diff] [review]
Fix for RTL

I wasn't thinking about RTL at all, I didn't realize we'd already done that
Attachment #233707 - Flags: review?(mconnor)
Attachment #233707 - Flags: review+
Attachment #233707 - Flags: approval1.8.1?
Attachment #233707 - Flags: approval1.8.1+

Comment 17

11 years ago
Landing RTL fix on branch.
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.