347463 - Proxy icon (favicon) in location bar scaled badly when feed or lock icon displayed

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Mentovai]

When the feed or lock icons are displayed in the location bar, the height of the location bar increases.  Open a site without any extra icons (such as http://www.google.com/) in one tab, and open a site with a feed icon (such as http://www.mozilla.org) in another tab.  Switch between the two tabs.  Notice how the location bar grows and shrinks vertically.  Ew.

One particularly nasty manifestation of this bug is that the page proxy icon (favicon) will expand to 16x18px when the feed or lock icons are also displayed in the location bar.  The proxy icon appears stretched vertically.  This is nasty.

Comment 1

[Mark Mentovai]

Attachment: Fig. 1. Location bar stretched vertically due to lock icon, note the scaled favicon

This shot from a Gmail login screen makes it easy to see the problem.  It shows the Google favicon stretched to 16x18px in the location bar, but at its normal 16x16px size in the search bar.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Must be an issue with the pinstripe changes, I don't see this on windows.

Comment 3

[Dietrich Ayala (:dietrich)]

Attachment: fix

i initially just set a max-height on the favicon, but this caused the feed icon to be smushed, which uncovered the real problem: the image regions were incorrect for the feed icon.

the patch sets the proper image regions, and also sets a min-height for the feed icon and a max-height for the favicon to make things less fragile. however, are max/min sizes not enforced here for a reason that i'm not seeing?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

It's probably best to tweak the images, rather than changing the region boundaries to not be multiples of 18px.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 233275 [details] [diff] [review]
fix

> #feed-button[feeds] {
>   list-style-image: url("chrome://browser/skin/livemark-item.png");
>-  -moz-image-region: rect(0px, 36px, 18px, 18px);
>+  -moz-image-region: rect(1px, 36px, 17px, 18px);
>+  min-height: 16px;

is the min-height needed?

I'm not sure if we're using 18px elsewhere, so fixing image regions seems like the best path forward.

r+a=me, please remember that this is branch-only