347589 - BWC warnings

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

Issues causing compiler warnings in BWC (because they annoy me when compiling):

1436     NSString* curURL = [[self getBrowserWrapper] getCurrentURI];
should be removed

3141   BrowserTabViewItem* previouslySelected = [mTabBrowser selectedTabViewItem];
3163   BrowserTabViewItem* previouslySelected = [mTabBrowser selectedTabViewItem];
need casts

3282   [newView setUICreationDelegate:self];
BWC needs to list BrowserUICreationDelegate as a protocol it implements, and list the protocol function in its header (since it does in fact implement it)

3600       [[result itemWithTarget:self andAction:@selector(copyAddressToClipboard:)] setTitle:NSLocalizedString(@"Copy Addresses", @"")];
BWC.mm needs to #import NSMenu+Utils.h

Comment 1

[froodian (Ian Leue)]

1436 is in the patch for bug 179041.

If any new coders feel like doing these fixes, feel free.

Realistically though... -> me

Comment 2

[Peter Jaros (:peeja)]

Attachment: Fixes remaining warnings

This should fix everything but the first one, which has already been fixed. :)

Comment 3

[Stuart Morgan]

Comment on attachment 234126 [details] [diff] [review]
Fixes remaining warnings

Sweet, sweet warning-free BWC compilation.

r=me

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 234126 [details] [diff] [review]
Fixes remaining warnings

sr=pink

off topic, what are we doing about the millions of warnings when building gcc4 with the 10.4 sdk?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> off topic, what are we doing about the millions of warnings when building gcc4
> with the 10.4 sdk?

Waiting for people using that config to file bugs?  Except for the people on Intel who have to use that config, I believe everyone is using the "release" PPC config of gcc 3.3 and 10.2.8 SDK.

Comment 6

[Håkan Waara]

(In reply to comment #4)
> off topic, what are we doing about the millions of warnings when building gcc4
> with the 10.4 sdk?
> 

We just (finally!) filed bug 349948 to get rid of the no-non-virtual-destructor warnings, by the way.

Checked in.