347698 - Tooltip instructs user to "click go" but Go button is no longer labelled "Go"

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Thomas Rutter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060806 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060806 BonEcho/2.0b1

The go button is no longer labelled "Go" (even with icons and text).  The tooltip for this button still contains the text:

"Type a location in the Location Bar, then click Go"

The button doesn't contain the word "Go" on it anywhere.  "...click the button next to the location bar with the green arrow" is too wordy.

Suggestions:

1. "Type a location into the Location Bar, then click this button"
2. "Type a location into the Location Bar, then click the green arrow"




Reproducible: Always

Comment 1

[Simon Bünzli]

Note that the Search-Go button doesn't have a tooltip, and neither does the address bar nor the search bar. So a further suggestion is to remove that tooltip altogether (otherwise please file a bug to add a tooltip to at least the Search-Go button).

Comment 2

[Myk Melez [:myk] [@mykmelez]]

The lack of text on this button is bug 347576, which is apparently being fixed by  the fix for bug 347754.  Even so, it'd still make sense to update this tooltip to reflect the fact that the button won't say "Go" by default.  I recommend:

  Type a location into the Location Bar, then click this button to go to it.

cc:ing beltzner for his UI blessings.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

--> firefox2beta2, taking to make string change

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes tooltip for Go button

Drivers: simple string change, requesting a? at same time as r? for expedience, should be reviewed and landed on trunk by the time we get to triage tomorrow :)

Comment 5

[Reed Loden [:reed]]

Comment on attachment 233970 [details] [diff] [review]
changes tooltip for Go button

>                        label="&goButton.label;"
This needs to be changed, too.

Notice you changed the name here:

>+<!ENTITY goEndCap.label               "Go">

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes tooltip for Go button v2

Huh. I swear I searched LXR and didn't turn up anything that had that entity. Guess I should have looked up. Fixed in this patch.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 233971 [details] [diff] [review]
changes tooltip for Go button v2

oh, it exists on trunk still, just not branch...

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes tooltip for Go button (branch version)

Oh, well, then this branch patch is the one that should be getting 1.8.1 approval :)

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 233974 [details] [diff] [review]
changes tooltip for Go button (branch version)

r+a=me on behalf of drivers for 1.8 branch checkin

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.xul 	1.268.2.56
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.25.2.25

Comment 11

[Peter Kasting]

Is this still [checkin needed] to commit https://bugzilla.mozilla.org/attachment.cgi?id=233971 to the trunk, or can it be RESOLVED FIXED?

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.53
mozilla/browser/base/content/browser.xul 	1.317

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081304 Minefield/3.0a8pre and Linux/Windows XP builds.