Tooltip instructs user to "click go" but Go button is no longer labelled "Go"

VERIFIED FIXED in Firefox 2 beta2

Status

()

Firefox
Toolbars and Customization
--
trivial
VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: Thomas Rutter, Assigned: beltzner)

Tracking

({fixed1.8.1, late-l10n})

2.0 Branch
Firefox 2 beta2
x86
Windows XP
fixed1.8.1, late-l10n
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2 theme change])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060806 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060806 BonEcho/2.0b1

The go button is no longer labelled "Go" (even with icons and text).  The tooltip for this button still contains the text:

"Type a location in the Location Bar, then click Go"

The button doesn't contain the word "Go" on it anywhere.  "...click the button next to the location bar with the green arrow" is too wordy.

Suggestions:

1. "Type a location into the Location Bar, then click this button"
2. "Type a location into the Location Bar, then click the green arrow"




Reproducible: Always
(Reporter)

Updated

12 years ago
Blocks: 347454

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 1

12 years ago
Note that the Search-Go button doesn't have a tooltip, and neither does the address bar nor the search bar. So a further suggestion is to remove that tooltip altogether (otherwise please file a bug to add a tooltip to at least the Search-Go button).

Updated

12 years ago
Assignee: nobody → mconnor
Flags: blocking-firefox2+
Whiteboard: [Fx2 theme change]
The lack of text on this button is bug 347576, which is apparently being fixed by  the fix for bug 347754.  Even so, it'd still make sense to update this tooltip to reflect the fact that the button won't say "Go" by default.  I recommend:

  Type a location into the Location Bar, then click this button to go to it.

cc:ing beltzner for his UI blessings.
--> firefox2beta2, taking to make string change
Assignee: mconnor → beltzner
Target Milestone: --- → Firefox 2 beta2
Status: NEW → ASSIGNED
Version: unspecified → 2.0 Branch
Created attachment 233970 [details] [diff] [review]
changes tooltip for Go button

Drivers: simple string change, requesting a? at same time as r? for expedience, should be reviewed and landed on trunk by the time we get to triage tomorrow :)
Attachment #233970 - Flags: review?(mconnor)
Attachment #233970 - Flags: approval1.8.1?

Updated

12 years ago
Attachment #233970 - Flags: review?(mconnor) → review+
Comment on attachment 233970 [details] [diff] [review]
changes tooltip for Go button

>                        label="&goButton.label;"
This needs to be changed, too.

Notice you changed the name here:

>+<!ENTITY goEndCap.label               "Go">
Attachment #233970 - Flags: review-
Attachment #233970 - Flags: review+
Attachment #233970 - Flags: approval1.8.1?
Created attachment 233971 [details] [diff] [review]
changes tooltip for Go button v2

Huh. I swear I searched LXR and didn't turn up anything that had that entity. Guess I should have looked up. Fixed in this patch.
Attachment #233970 - Attachment is obsolete: true
Attachment #233971 - Flags: review?(mconnor)
Attachment #233971 - Flags: approval1.8.1?
Comment on attachment 233971 [details] [diff] [review]
changes tooltip for Go button v2

oh, it exists on trunk still, just not branch...
Attachment #233971 - Flags: review?(mconnor) → review+
Created attachment 233974 [details] [diff] [review]
changes tooltip for Go button (branch version)

Oh, well, then this branch patch is the one that should be getting 1.8.1 approval :)
Attachment #233974 - Flags: review?(mconnor)
Attachment #233974 - Flags: approval1.8.1?
Attachment #233971 - Flags: approval1.8.1?
Keywords: late-l10n
Comment on attachment 233974 [details] [diff] [review]
changes tooltip for Go button (branch version)

r+a=me on behalf of drivers for 1.8 branch checkin
Attachment #233974 - Flags: review?(mconnor)
Attachment #233974 - Flags: review+
Attachment #233974 - Flags: approval1.8.1?
Attachment #233974 - Flags: approval1.8.1+
Whiteboard: [Fx2 theme change] → [checkin needed][Fx2 theme change]
mozilla/browser/base/content/browser.xul 	1.268.2.56
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.25.2.25
Keywords: fixed1.8.1

Comment 11

12 years ago
Is this still [checkin needed] to commit https://bugzilla.mozilla.org/attachment.cgi?id=233971 to the trunk, or can it be RESOLVED FIXED?
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.53
mozilla/browser/base/content/browser.xul 	1.317
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed][Fx2 theme change] → [Fx2 theme change]
Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081304 Minefield/3.0a8pre and Linux/Windows XP builds.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.