Closed
Bug 347796
Opened 18 years ago
Closed 18 years ago
Borders disappear when collapsing files on Bugzilla's "diff" view
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
People
(Reporter: uriber, Assigned: bernd_mozilla)
References
()
Details
(4 keywords)
Attachments
(2 files)
|
793 bytes,
text/html
|
Details | |
|
1017 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
dveditz
:
approval1.8.0.7+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Go to the URL above or to a "diff" view of any other patch in Bugzilla. Press "Collapse all" (or just manually collapse some files by clicking the (-) "twisties"). Notice that the thin black border around the gray header of each collapsed file disappears (except for the right edge, which remains). This regressed between 2006-08-04 and 2006-08-05, so it's almost certainly due to bug 343807. Thanks to Martijn for helping me find that. A minimal testcase is coming up soon.
|
Reporter | |
Comment 1•18 years ago
|
||
This demonstrates the problem: - The table has border-collapse: collapse - The <thead> has a border - When dynamically setting the <tbody> style to "display:none", not only the bottom border disappears, but also the left and top borders.
|
|
Reporter | |
Comment 3•18 years ago
|
||
I did(In reply to comment #2) > Maybe you meant bug 343087. > I did, of course. Thanks for the correction and sorry for the confusion.
Depends on: 343087
|
||
Comment 4•18 years ago
|
||
Testcase WFM using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060817 Minefield/3.0a1 ID:2006081709 [cairo]
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
Attachment #235564 -
Flags: superreview?(bzbarsky)
Attachment #235564 -
Flags: review?(bzbarsky)
Attachment #235564 -
Flags: approval1.8.1?
Comment on attachment 235564 [details] [diff] [review] patch asking for approval in case that bug 346980 gets approval.
Attachment #235564 -
Flags: approval1.8.0.7?
|
||
Updated•18 years ago
|
Whiteboard: [r/sz bz]
|
||
Updated•18 years ago
|
Attachment #235564 -
Flags: superreview?(bzbarsky)
Attachment #235564 -
Flags: superreview+
Attachment #235564 -
Flags: review?(bzbarsky)
Attachment #235564 -
Flags: review+
|
|
||
Updated•18 years ago
|
Whiteboard: [r/sz bz] → [land on trunk[
|
|
||
Comment 7•18 years ago
|
||
Comment on attachment 235564 [details] [diff] [review] patch a=schrep/beltnzer for drivers.
Attachment #235564 -
Flags: approval1.8.1? → approval1.8.1+
|
||
Comment 8•18 years ago
|
||
Comment on attachment 235564 [details] [diff] [review] patch approved for 1.8.0 branch, a=dveditz for drivers Please land today
Attachment #235564 -
Flags: approval1.8.0.7? → approval1.8.0.7+
fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [land on trunk[
Keywords: fixed1.8.0.7
|
||
Comment 10•18 years ago
|
||
v.fixed on 1.8.0 branch, table borders are all ok: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060829 Firefox/1.5.0.7 However, I still see the bug with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1b2) Gecko/20060830 BonEcho/2.0b2. This is already approved for 1.8.1, so this should land there as well.
Keywords: fixed1.8.0.7 → verified1.8.0.7
|
||
Updated•18 years ago
|
Flags: blocking1.8.1?
|
||
Updated•18 years ago
|
Whiteboard: [checkin needed (1.8 branch)]
|
|
||
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
Assignee | |
Comment 11•18 years ago
|
||
fixed on 1.8.1
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
You need to log in
before you can comment on or make changes to this bug.
Description
•