347822 - mysql_num_rows() warning when uploading extension

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Justin Scott [:fligtar]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6

PHP gives a warning when uploading an extension:

Warning: Wrong parameter count for mysql_num_rows() in /developers/additem.php on line 319

mysql_num_rows() only takes the result resource, not the connection.

Reproducible: Always

Comment 1

[Justin Scott [:fligtar]]

Attachment: patch

Patches developers/additem.php to remove the bad parameter. Note that this will actually make the duplicate version check work now, so it won't be possible to upload a version with the same version number as an existing one.

Comment 2

[Cameron]

I'm wondering why we don't already have a bug on this!

Comment 3

[Michael Morgan [:morgamic]]

Comment on attachment 232642 [details] [diff] [review]
patch

This was a stupid error on my part.  The error was good, though, since we still do want to allow multiple files per version -- which would be impossible if this piece was working.  I have a patch for the dupe version check that allows the multiple-files-per-os scenario.

Comment 4

[Michael Morgan [:morgamic]]

Attachment: Patch to add OSID to dupe check for uploads.

Comment 5

[Cameron]

r+ is from fligtar, but he doesn't have editbugs.

Comment 6

[Michael Morgan [:morgamic]]

This has been checked in.  Will be pushed with next update.