347847 - Sanitize venkman-overlay (akey -> accesskey)

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.4) Gecko/20060614 Fedora/1.5.0.4-1.2.fc5 Firefox/1.5.0.4 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.4) Gecko/20060614 Fedora/1.5.0.4-1.2.fc5 Firefox/1.5.0.4 pango-text

See provided patch

Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: Clean up venkman-overlay.dtd (akey->accesskey, whitespace alignment) and venkman-overlay.xul (akey->accesskey, minor typo in comment)

Comment 2

[James Ross]

Comment on attachment 232679 [details] [diff] [review]
Clean up venkman-overlay.dtd (akey->accesskey, whitespace alignment) and venkman-overlay.xul (akey->accesskey, minor typo in comment)

>Index: extensions/venkman/resources/locale/en-US/venkman-overlay.dtd

>+<!ENTITY venkmanCmd.label			"JavaScript Debugger">

Since you're fixing the alignment here, please remove all the tabs in this line as well.

r=silver with that fixed

Comment 3

[Giacomo Magnini]

Attachment: What James asked.

Comment 4

[James Ross]

Giacomo, do you have CVS write access? If not, add [checkin needed] to the status Whiteboard and we'll sort out checking it in.

Comment 5

[Giacomo Magnini]

I was looking for a sr actually: not sure about review policies for this.
James: can we discuss a bit what to do with CZ? There is much work to do there...

Comment 6

[James Ross]

For Venkman, no sr is required. Discussions regarding ChatZilla should probably go into #chatzilla (I'm around a bit as [Not]Silver and from Friday back as Silver).

Comment 7

[Giacomo Magnini]

James, can you please check this in for me?
TIA, Giacomo.

Comment 8

[James Ross]

Sorry about the delay.

Checked in --> FIXED.