347858 - Sanitize search.properties (both SM and TB)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.4) Gecko/20060614 Fedora/1.5.0.4-1.2.fc5 Firefox/1.5.0.4 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.4) Gecko/20060614 Fedora/1.5.0.4-1.2.fc5 Firefox/1.5.0.4 pango-text

See included patch.

Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: Fix accesskey -> .accesskey's in .properties file and their use in ABSearchDialog.js and SearchDialog.js

Comment 2

[David :Bienvenu]

does this have any semantic difference? .accessKey is .dtd syntax, not .properties syntax, as far as I know...

Comment 3

[Giacomo Magnini]

(In reply to comment #2)
> does this have any semantic difference? .accessKey is .dtd syntax, not
> .properties syntax, as far as I know...
> 

This will help localizers and their tools in keeping strings and accesskeys coupled and easily verifiable. See bug 314875 and the discussions here:
http://groups.google.com/group/mozilla.dev.l10n/browse_thread/thread/6ea914ca7f090273/282b9e7ad23ae72e?lnk=raot&hl=en#282b9e7ad23ae72e
and here:
http://groups.google.com/group/mozilla.dev.l10n/browse_thread/thread/fcd201c147a1c554/01dd51facafe6050?lnk=raot&hl=en#01dd51facafe6050

Comment 4

[Giacomo Magnini]

(In reply to comment #3)
> bug 314875

Sorry, bug 314785.

Comment 5

[David :Bienvenu]

Comment on attachment 232700 [details] [diff] [review]
Fix accesskey -> .accesskey's  in .properties file and their use in ABSearchDialog.js and SearchDialog.js

ok, thx.

Comment 6

[Giacomo Magnini]

Comment on attachment 232700 [details] [diff] [review]
Fix accesskey -> .accesskey's  in .properties file and their use in ABSearchDialog.js and SearchDialog.js

I guess sr is needed here. Oh, and if you don't mind checking this in also... ;)

Comment 7

[David :Bienvenu]

Comment on attachment 232700 [details] [diff] [review]
Fix accesskey -> .accesskey's  in .properties file and their use in ABSearchDialog.js and SearchDialog.js

yes, I can check this in. Thx for the patch

Comment 8

[David :Bienvenu]

fixed on trunk.

Comment 9

[David :Bienvenu]

fixed on the 1.8.1 branch 

Comment 10

[Axel Hecht [:Pike]]

Any reason why we're not using StopButton.label and StopButton.accesskey?

Comment 11

[Giacomo Magnini]

(In reply to comment #10)
> Any reason why we're not using StopButton.label and StopButton.accesskey?

I've discovered myself people don't like much when you are messing around their files, so I tried to go with the minimum impact. If David thinks I can patch deeper, I will happily do, but this will result in more false "new" strings for localizers. Just tell me.