Closed Bug 347868 Opened 18 years ago Closed 18 years ago

Accesskeys names for sizes' fonts for the advanced preference font window should be more explicit

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 alpha1

People

(Reporter: cedric.corazza, Assigned: cedric.corazza)

References

Details

Attachments

(1 file)

Patch changing the accesskey names
2.07 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
These accesskeys are named size.accesskey1 and size.accesskey2. This is not explicit and don't follow the Mozilla development naming rules. It also blocks bug 314785

        Attachment #232710 -
        Flags: review?

    
    

    
  
Could someone review this as it is a trivial patch?
Version: unspecified → Trunk

    
    

    
  
Comment on attachment 232710 [details] [diff] [review]
Patch changing the accesskey names

Ah, no one noticed this because the review request doesn't have a specific requestee. Make sure to pick one next time :)

        Attachment #232710 -
        Flags: review? → review+
Whiteboard: [checkin needed]

    
    

    
  
mozilla/browser/components/preferences/fonts.xul 	1.18
mozilla/browser/locales/en-US/chrome/browser/preferences/fonts.dtd 	1.12
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: