347946 - Sidebar and notification bar close buttons should behave like Tab close button - activate red on mouse over

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Tracy Walker [:tracy]]

On Mac for consistency of the close button look and behavior if we're going to have the tabs turn red on mouse over, then let's have the sidebar close button turn red as well.  Windows behavior is consistent between the two buttons.

Comment 1

[Dão Gottwald [:dao]]

Why does this block bug 347754?

Comment 2

[Phil Ringnalda (:philor)]

Because, to avoid typoing the number, I carefully copied and pasted the wrong number.

Comment 3

[Asaf Romano (gone)]

See also bug 347399.

I think we should always use the hover-style image for the close button of the selected tab, and for the sidebar's one.

Comment 4

[Phil Ringnalda (:philor)]

We should give the notificationbox close button some lovin' too: little bitty grey spot next to a looming Preferences button, without even a tooltip to its name, it could use some color in its life.

Comment 5

[Peter Kasting]

Nominating so beltzner will see this and make a decision on it

Comment 6

[Mike Connor [:mconnor]]

Seth seems bored... should just be CSS, also need to fix the weird offset while we're there!

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: screen shot after the fix for the close button (on hover) on the notification bar

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: screen shot after the fix for the close button (on hover) of the side bar

Comment 10

[(not reading, please use [e-mail] instead)]

for both the sidebar and the notification box (thanks to phil for pointing it out) I've fixed the hover state and fixed the weird offset (thanks to mconnor for pointing it out.)

Comment 11

[(not reading, please use [e-mail] instead)]

phil wrote:

"We should give the notificationbox close button some lovin' too: little bitty
grey spot next to a looming Preferences button, without even a tooltip to its
name, it could use some color in its life."

1) bug logged on that button missing a close tooltip, see bug #351639

2) bug logged on how close the blue alert icon is to the left hand side of the notification bar.  see bug #351640

Comment 12

[Mike Connor [:mconnor]]

Comment on attachment 237086 [details] [diff] [review]
patch

r+a=me, thanks Seth!

Comment 13

[(not reading, please use [e-mail] instead)]

fix landed on the branch.  thanks for the quick r/a!