Closed
Bug 347946
Opened 19 years ago
Closed 18 years ago
Sidebar and notification bar close buttons should behave like Tab close button - activate red on mouse over
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 2
People
(Reporter: tracy, Assigned: moco)
References
Details
(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])
Attachments
(3 files)
2.10 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
47.87 KB,
image/jpeg
|
Details | |
47.56 KB,
image/jpeg
|
Details |
On Mac for consistency of the close button look and behavior if we're going to have the tabs turn red on mouse over, then let's have the sidebar close button turn red as well. Windows behavior is consistent between the two buttons.
Comment 1•19 years ago
|
||
Why does this block bug 347754?
Comment 2•19 years ago
|
||
Because, to avoid typoing the number, I carefully copied and pasted the wrong number.
Comment 3•19 years ago
|
||
See also bug 347399.
I think we should always use the hover-style image for the close button of the selected tab, and for the sidebar's one.
Keywords: uiwanted
Comment 4•18 years ago
|
||
We should give the notificationbox close button some lovin' too: little bitty grey spot next to a looming Preferences button, without even a tooltip to its name, it could use some color in its life.
Comment 5•18 years ago
|
||
Nominating so beltzner will see this and make a decision on it
Flags: blocking-firefox2?
Whiteboard: [Fx2 theme change]
Target Milestone: --- → Firefox 2
Updated•18 years ago
|
Assignee: nobody → jgoldman
Flags: blocking-firefox2? → blocking-firefox2+
Updated•18 years ago
|
Assignee: jgoldman → mconnor
Flags: blocking-firefox2+ → blocking-firefox2?
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Comment 6•18 years ago
|
||
Seth seems bored... should just be CSS, also need to fix the weird offset while we're there!
Assignee: mconnor → sspitzer
Assignee | ||
Comment 7•18 years ago
|
||
Attachment #237086 -
Flags: review?(mconnor)
Assignee | ||
Comment 8•18 years ago
|
||
Assignee | ||
Comment 9•18 years ago
|
||
Assignee | ||
Comment 10•18 years ago
|
||
for both the sidebar and the notification box (thanks to phil for pointing it out) I've fixed the hover state and fixed the weird offset (thanks to mconnor for pointing it out.)
Status: NEW → ASSIGNED
Assignee | ||
Comment 11•18 years ago
|
||
phil wrote:
"We should give the notificationbox close button some lovin' too: little bitty
grey spot next to a looming Preferences button, without even a tooltip to its
name, it could use some color in its life."
1) bug logged on that button missing a close tooltip, see bug #351639
2) bug logged on how close the blue alert icon is to the left hand side of the notification bar. see bug #351640
Assignee | ||
Updated•18 years ago
|
Whiteboard: [Fx2 theme change] → [Fx2 theme change][fix in hand, awaiting review]
Comment 12•18 years ago
|
||
Comment on attachment 237086 [details] [diff] [review]
patch
r+a=me, thanks Seth!
Attachment #237086 -
Flags: review?(mconnor)
Attachment #237086 -
Flags: review+
Attachment #237086 -
Flags: approval1.8.1+
Assignee | ||
Comment 13•18 years ago
|
||
fix landed on the branch. thanks for the quick r/a!
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Summary: Sidebar close button should behave like Tab close button - activate red on mouse over → Sidebar and notification bar close buttons should behave like Tab close button - activate red on mouse over
Whiteboard: [Fx2 theme change][fix in hand, awaiting review] → [Fx2 theme change]
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
Reporter | ||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•