348099 - zh-CN Search Feature Tracking for Firefox 2

Status: VERIFIED FIXED

(Mozilla Localizations :: zh-CN / Chinese (Simplified), defect)

Description

[chris hofmann]

tracking bug to make sure we get things on the list below working correctly for
each locale:

Full Default Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Comment 1

[Shaohua Wen]

Any test case available for this?

Comment 2

[chris hofmann]

starting to work on it.

It appears that Google is listed first and Yahoo is second.  That order needs to be reversed.

Also I noticed on the laptop that I'm testing a build from 

that a yahoo search appears to return this seach query.

http://search.yahoo.com/search?p=test&ei=UTF-8&fr=moz2

I think I'm using a clean profile for testing, but it may be that some where along the line that the "fr" code has been kept.  Can some one check to see if they also see the "fr" tracking code.  The tracking code should indicate  zh-CN 	 s and the plugin should point to search.cn.yahoo.com

http://wiki.mozilla.org/Firefox2/L10n_Requirements#Search_Plugins has more info on the requirements...

Comment 3

[Axel Hecht [:Pike]]

Attachment: fix order in region.properties to point to en-US Yahoo first, Google second

This is a hack we may use for B2. This is not intended to be the full fix required to ship Firefox 2 for zh-CN, though, that will require to actually use the right plugins, too.

Comment 4

[chris hofmann]

Here is info to round out the first round of testing using 

¹¹½¨ ID:Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1b1) Gecko/20060729 BonEcho/2.0b1

which was the latest build found at
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8-l10n/firefox-2.0b1.zh-CN.win32.installer.exe  	5347 KB  	7/30/2006  	5:33:00 PM


An amazon search generated this query:
http://www.amazon.com/gp/search/104-7033932-3597535?search-alias=aps&keywords=test

and english content was returned.

looks like the amazon plugin also needs investigation to align with the spec in the areas of "tag" and "sourceid".  server and content looks like it complies with the spec to use www.amazon.com.  (Note: It appears that http://www.amazon.cn redirects to another site that might be squating. ( -> http://www.joyo.com/?source=amazoncn )

From the spec Amazon.com URLs follow this basic formula:

http://%DOMAIN%/exec/obidos/external-search/?field-keywords={searchTerms}&mode=blended&tag=mozilla-20&sourceid=Mozilla-search
%DOMAIN% 	Select from the table below
field-keywords=MY+SEARCH 	Search term
mode=blended 	Show results from all parts of the store
tag=mozilla-20 	Mozilla identifier #1
sourceid=Mozilla-search 	Mozilla identifier #2

If your domain is not listed, then Amazon may not provide a site for your locale. Most other locales used www.amazon.com in Firefox 1.5:
en-CA 	www.amazon.ca
en-GB 	www.amazon.co.uk
en-US 	www.amazon.com
de 	www.amazon.de
fr 	www.amazon.fr
ja 	www.amazon.co.jp


Other plugins generated these queries.

http://www.answers.com/main/ntquery?s=test&gwp=13
 --same as spec

http://search.creativecommons.org/?q=test&sourceid=Mozilla-search
 --same as spec

http://search.ebay.com/test_W0QQfrppZ50QQfsopZ1QQmaxrecordsreturnedZ300

 spec indicates zh-CN should point to http://search.ebay.com.cn

 eBay

eBay URLs follow this basic formula:

http://%DOMAIN%/search/search.dll

with a vast number of arguments:
query=SEARCH+TERMS
MfcISAPICommand=GetResult
ht=1
ebaytag1=ebayreg
srchdesc=n
maxRecordsReturned=300
maxRecordsPerPage=50
SortProperty=MetaEndSort

Of the tier 1 and 2 locales, these are the domains for those supported by eBay:
de 	search.ebay.de
en-GB 	search.ebay.co.uk
en-US 	search.ebay.com
es-ES 	search.ebay.es
fr 	search.ebay.fr
it 	search.ebay.it
nl 	search.ebay.nl
pl 	search.ebay.pl
sv-SE 	search.ebay.se
zh-CN 	search.ebay.com.cn
zh-TW 	search.tw.ebay.com

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 235557 [details] [diff] [review]
fix order in region.properties to point to en-US Yahoo first, Google second

Checked in the MOZILLA_1_8_BRANCH on behalf of drivers for Firefox 2 B2.

Comment 6

[chris hofmann]

I installed the respun beta candidate on another system
---¹¹½¨ ID:Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1b2) Gecko/2006082101 Firefox/2.0b2

but I still see it going to the wrong server...
http://search.yahoo.com/search?p=test&ei=UTF-8&fr=moz2

not
http://search.cn.yahoo.com/?p=test&ei=UTF-8&fr=moz2
which appears to be live, or
http://www.yahoo.cn/?p=test&ei=UTF-8&fr=moz2
where I get redirected to from 
http://search.cn.yahoo.com

I wonder where yahoo wants searches to go for zh-CN?

we should figure the most direct path where these searches should go, 
and then fix the build to not go to http://search.yahoo.com

Comment 7

[chris hofmann]

mic, can you check with yahoo on the correct server?

Comment 8

[Mic Berman]

working on it...

Comment 9

[Michael Albers]

For China, the url should point to the following:

http://search.cn.yahoo.com/search?p=<string>&ei=UTF-8&fr=moz1

I'll confirm on the &fr= paramater to be sure, but for now please use this url.

Comment 10

[Michael Albers]

For China, the url should point to the following:

http://search.cn.yahoo.com/search?p=<string>&ei=UTF-8&fr=moz1

I'll confirm on the &fr= paramater to be sure, but for now please use this url.

Comment 11

[chris hofmann]

just a note to make sure the yahoo code is correct
fr=moz1      %IDENTIFIER% when Yahoo is in the #1 search position
fr=moz2      %IDENTIFIER% when Yahoo is in the #2 search position

Comment 12

[Axel Hecht [:Pike]]

Some of the 1.5 work is loosely tracked in bug 316670.

1.5 ships with

yahoo-cn
google
amazondotcom
baidu
eBay-zh-CN
taobao

Sounds like we should have a yahoo-cn.xml, ebay-zh-CN. The google and amazondotcom plugins can be cvs removed, as they're picked up from en-US by the build.

Holy, do you want to add baidu and taobao back for 2.0? If so, do you have points of contact, and Terms of Use? Those would be of interest to Mic.

Comment 13

[Axel Hecht [:Pike]]

From my limited understanding of things, it looks like joyo.com is the .cn partner of Amazon. Is that true? Should we investigate to move over to them? Maybe our amazon contacts can help out here, too.

Comment 14

[Shaohua Wen]

(In reply to comment #13)
I have no points of contact or term of use...
baidu and taobao is added just because they are used widely in china.

Comment 15

[Axel Hecht [:Pike]]

... doesn't answer the question if you want to add baidu and taobao back for 2.0.

To make things a bit more precise, for search engines we shipped with in 1.5, we don't require to have the contact information right away, assuming that they know by know and are fine with being in Firefox. But it'd be good to make progress on that in parallel.

Comment 16

[Mike Schroepfer]

Michael/Mic can you confirm whether the search tracking code should be:

fr=fx2-moz-1 or f=D3_g as indicated on:

http://wiki.mozilla.org/Firefox2/L10n_Requirements

Comment 17

[Shaohua Wen]

(In reply to comment #15)
> ... doesn't answer the question if you want to add baidu and taobao back for
> 2.0.
> 
what actions are needed for adding them back?
should we contact baidu or taobao ?

Comment 18

[Axel Hecht [:Pike]]

(In reply to comment #17)
> (In reply to comment #15)
> > ... doesn't answer the question if you want to add baidu and taobao back for
> > 2.0.
> > 
> what actions are needed for adding them back?

You need to port your sherlock plugins over to MozSearch, http://developer.mozilla.org/en/docs/Creating_MozSearch_plugins has details.

> should we contact baidu or taobao ?

Yes, and please CC Mic, preferably on English mails, of course.

Comment 19

[Mic Berman]

comment #16
i've asked malbers from yahoo to reconfirm. he will do so within 12 hours
thanks
mic

Comment 20

[Shaohua Wen]

mic, 
  Can you give me an example letter to contact yahoo? I don't know what to ask for...
Thanks,Holy

Comment 21

[Michael Albers]

no need for the "fr=" code, but do need the f code as follows:

Default moz build (yahoo is default): f=D3_g
Yahoo partner build: f=D4_g

I had updated the l10n wiki but forgot to update this bug previously. Let me know if you have questions.

Holy, not sure I understand your question on "example letter" ?

Comment 22

[Shaohua Wen]

(In reply to comment #21)
> Holy, not sure I understand your question on "example letter" ?
> 
I mean : what kind of permission what we need from yahoo/taobao/baidu to add a search plugin to firefox? do we need some official document to authorize that from yahoo/taobao/baidu?

Comment 23

[Shaohua Wen]

Attachment: baidu.xml

Comment 24

[Shaohua Wen]

Attachment: taobao.xml for taobao search

Comment 25

[Axel Hecht [:Pike]]

(In reply to comment #22)
> (In reply to comment #21)
> > Holy, not sure I understand your question on "example letter" ?
> > 
> I mean : what kind of permission what we need from yahoo/taobao/baidu to add a
> search plugin to firefox? do we need some official document to authorize that
> from yahoo/taobao/baidu?

You don't need to worry about Yahoo, we have plenty of contacts there.

For taobao and baidu, Mic needs an informal statement that they are fine with exposing their brands as part of the search plugin, and that they're happy with the traffic. In addition to that, we'd like to have a contact partner to reach out to in case of questions.

Comment 26

[Michael Albers]

As the Yahoo! rep, we have a contract in place and you have our permission.

Comment 27

[Shaohua Wen]

Can we checkin the plugins now or we have to wait the answer from taobao/baidu?

Comment 28

[Axel Hecht [:Pike]]

Check them in, as they were in 1.5, we can land them now and check their feedback later.

Changing whiteboard, bsmedberg fixed the yahoo plugin, no BD approval needed as no change compared to 1.5. Contact pending, but that's OK for now.

Comment 29

[Mic Berman]

hey all,
it's my understanding that we're up to 8 search plug-ins now with the addition of answers and creative commons. these two, answers and creative commons i don't beleive make a material impact in the chinese user experience. as such, please remove them from the plug-in list. if i've misunderstood and this was a purposeful addition, please advise as to rationale
thanks
mic

Comment 30

[Shaohua Wen]

(In reply to comment #29)
  I agree with you,and in firefox 1.5 Simplified Chinese version ,we removed them.
  @Axel, should I remove them ?

Comment 31

[Axel Hecht [:Pike]]

So, I did two check-ins:

As the build systems picks up plugins of a matching name from en-US, if it can, I cvs removed all the duplicate .xml files in the Chinese localization. I copied the eBay.xml over to eBay-zh-CN.xml, and checked it in on trunk, and then branched.

In the future, please make sure to branch files to MOZILLA_1_8_BRANCH, by doing a 

cvs tag MOZILLA_1_8_BASE
cvs tag -b MOZILLA_1_8_BRANCH

If you don't do the '-b' for the branch tag, you add major problems.

So, in addition to the eBay -> eBay-zh-CN, I also removed answers and creative commons.

I'll let the trees cycle for a bit to pick up the changes, I hope that no further changes are going to be required.

Comment 32

[Axel Hecht [:Pike]]

Marking FIXED, my tools say that things should work fine.

Holy, could you please try an upcoming nightly? Please make sure that all plugins work with chinese input, in particular the ebay one.

All plugins should be tested, on a clean profile, and if they work as expected, please mark this bug as VERIFIED.

Thanks