351817 - Implement pref-based search parameters

Status: RESOLVED FIXED

(Firefox :: Search, enhancement)

Description

[Benjamin Smedberg]

For various partner builds we'd like to be able to set search parameters based on the value of a pref, rather than hardcoding the value into the searchplugin. This should use a special prefbranch so that searchplugins installed off the web don't have access to random preferences.

Gavin's proposed syntax:

<MozParam name="fr" condition="pref" pref="yahoo-fr" />

with pref("browser.search.param.yahoo-fr", "moz2");

will produce fr=moz2 as a search parameter.

Comment 1

[Benjamin Smedberg]

Per partner-build discussion, would really like to get this in for FF2.

Comment 2

[Benjamin Smedberg]

Attachment: <MozParam condition="pref">

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 237342 [details] [diff] [review]
<MozParam condition="pref">

Please indent all the code under the case and the case itself another 2 spaces, and put the catch on the same line as the closing brace, to match this file's style.

It would also be a good idea to post to m.d.l10n to notify localizers of this change, so they can fix their Yahoo plugins.

Comment 4

[Benjamin Smedberg]

Attachment: Fix localized searchplugins, rev. 1

Comment 5

[Axel Hecht [:Pike]]

More importantly, schrep should include this fix in the l10n requirements doc.

Comment 6

[Benjamin Smedberg]

Where is that doc?

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 237349 [details] [diff] [review]
Fix localized searchplugins, rev. 1

For what I know, the russian yahoo plugin should get the fr= code removed, as it doesn't have the plugin on position 2. Confirm with schrep.

With that, r/a=me, I think we should be good to land that ourselves, if we feel like it. It would certainly take some pressure out of the release process.

Comment 8

[Benjamin Smedberg]

Code bits fixed on trunk. I'm not going to mess with non-English searchplugins for the moment.

Comment 9

[Mike Schroepfer]

1) Doc is here:

http://wiki.mozilla.org/Firefox2/L10n_Requirements

2) What would you like me to add?

3) If Russia is in #3 you can remove the parm

4) You guys rock!

Comment 10

[Axel Hecht [:Pike]]

I would think that the requirements doc should have a How-To section similar to the one that Google has, with something like

'''How To:'''
Locales with a dedicated yahoo service should create a yahoo-ab-CD.xml. The <code>fr</code> search param should be implemented as

 <MozParam name="fr" condition="pref" pref="yahoo-fr-cjkt" />

for China, Japan, Korea, or Taiwan, and as

 <MozParam name="fr" condition="pref" pref="yahoo-fr" />

for all other which have Yahoo as second search engine. Locales which don't give an explicit order for Yahoo should not pass a <code>fr</code> parameter.

</end of suggested phrase>

We need to get a confirmation/validation on the Simplified Chinese special search param f=D3_g, or its removal.

Comment 11

[Mike Schroepfer]

Comment on attachment 237342 [details] [diff] [review]
<MozParam condition="pref">

a=schrep for drivers

Comment 12

[Benjamin Smedberg]

Both attachments fixed on MOZILLA_1_8_BRANCH