348124 - gu-IN = Gujarati Search Feature Tracking for Firefox 2

Status: RESOLVED FIXED

(Mozilla Localizations :: gu-IN / Gujarati, defect)

Description

[chris hofmann]

tracking bug to make sure we get things on the list below working correctly for
each locale:

Full Default Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Comment 1

[Axel Hecht [:Pike]]

Ankit, you're currently using a plain copy of the en-US plugins, we should have a Indian version for both Yahoo and eBay, as we did for 1.5.

Regarding the other plugins, the list.txt picks them up from en-US, so you can safely cvs remove the .xml files that are just plain copies.

Comment 2

[Ankit Patel]

Hi Alex,

I have corrected the searchplugin issue in the firefox & commited into CVS. Can you please check whether it's correct or not?

Comment 3

[Axel Hecht [:Pike]]

You should just use the plain google.xml plugin, instead of adding google-in.xml.
That just needs an entry 'google' in list.txt. Google wants us to use just that one entry point.

Mic, gu-IN currently has google, yahoo india and ebay india as search plugins, are that enough? wikipedia on gujarati has 200 articles, doesn't sound worthwhile to me.

Comment 4

[Ankit Patel]

Hi Alex,

Reverted back to google.xml , eBay.xml & yahoo.xml with .in entries... Please tell me if still anything wrong.

Comment 5

[Axel Hecht [:Pike]]

ankit, why not split exactly where I tell you?

eBay and Yahoo need indian plugins.

Google does not.

You should have ebay-in.xml and yahoo-in.xml, but no google*.xml.

list.txt should look like

google
yahoo-in
ebay-in

Comment 6

[Ankit Patel]

Updated again.

Sorry for the mistake...

Comment 7

[Axel Hecht [:Pike]]

Technical review is OK.

Mic, if you're fine with Google, Yahoo! India and eBay India, you can close this bug.

Comment 8

[Mic Berman]

BD has reviewed and is good to go with 3 plug ins: Google, Yahoo! India and eBay India
Ankit - in future if you wish to add any additional plug ins, please create a new bug or contact me directly. We would need a logical rationale, contact name and email address and permission from them to do so. 
Thanks
mic