348344 - Form History is not saved if customize toolbar dialog was opened

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Loune]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060713 BonEcho/2.0b1

Any new form entry will not be saved into the form history across sessions, if the customize toolbar dialog is opened during that session.

Reproducible: Always

Steps to Reproduce:
1. Open firefox
2. Open customize toolbar (right click on toolbar > customise)
3. Click 'Done' on customize dialog
4. type abcabcabc into search bar
5. Close firefox
6. Open firefox
7. type abc into search bar

Actual Results:  
abcabcabc is not shown as a previously search item

Expected Results:  
abcabcabc should be shown

Some debugging revealed that nsFormHistory never gets destroyed.

Comment 1

[Jackie Liu]

I can confirm this in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060812 BonEcho/2.0b1.

Comment 2

[Frédéric Buclin]

looks like a dupe of bug 348016

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Not going to block the release for this edge case, but it would be nice to get the fix.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I'm guessing this is because the XBL destructor for the search bar binding isn't being fired for the search bar widget created for the toolbarpallette, so a reference to the form history service (via _formHistSvc) is kept indefinitely, so it's shutdown code never runs.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

This works for me on the latest Nightly.