Closed Bug 348481 Opened 18 years ago Closed 16 years ago

Unifinder: focus is lost when moving between events via up & down key

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: damian.publicemail, Assigned: maxxmozilla)

References

Details

Attachments

(1 file)

917 bytes, patch
berend.cornelius09
: review+
Details | Diff | Splinter Review
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060812 Calendar/0.3a2+

Well, this is not a bug, but it would be nice if you can improve surfing in unifinder. Sometimes when you press down/up you lose focus which goes to main menu - then you can not move to another event unless you move focus back.

Reproducible: Always

Steps to Reproduce:
1. create two events with differend dates: first day of May and first of August
2. select first item in unifinder
3. press down on your keyboard
   -> you lost focus and can not use up/down unless unifinder gain focus (again)



Expected Results:  
when you navigate between events via unifinder, focus is not lost, unifinder is focused

problem appears when you switch between two events which are not visible at the same moment in main menu
when you change selection in unifinder you send event to reload items and then you lose focus - unable to continue navigation via unifinder
when you navigate between items which are visible in main view and reloading is not necessary - works fine so behaviour should be similar for all events

not sure if this is easy to change, however currently behaviour is not homogeneous

--enhancement
Version: unspecified → Trunk
On click you have no problems to navigate through the events in the unifinder, but with up & down key you can't do this easily, when actually selected event and next event are not visible in the same view.

Changing from RFE to Bug because of misbehavior in UI handling.
Severity: enhancement → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: unifinder: focus is lost when moving between events with differend dates → Unifinder: focus is lost when moving between events not visible in the same view via up & down key
This is pretty easy to fix, once we know whether the unifinder was the one doing the original selection or not.  Let's get our selection architecture firmed up in bug 321384 before writing a patch here that will just have to be re-done afterwards.  Note also that this bug is probably the root cause of bug 347785
Blocks: 347785
Depends on: 321384
With Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7pre) Gecko/20070804 Calendar/0.7pre you can't use up & down key to navigate in unifinder (only one up or down move possible before selection lost).
Summary: Unifinder: focus is lost when moving between events not visible in the same view via up & down key → Unifinder: focus is lost when moving between events via up & down key
I want to point out that it's not just a focus issue but a performance issue as well -- there's a lot of refetching/repainting going on.
Flags: blocking-calendar0.8?
The focus issue doesn't block. Since we should follow the "one issue per bug"-rule, I reopened bug 416158 and renamed to just apply to the perf issue.
Flags: blocking-calendar0.8? → blocking-calendar0.8-
Flags: blocking-calendar0.8- → wanted-calendar0.9?
Flags: wanted-calendar0.9? → wanted-calendar0.9-
Attached patch Patch v1Splinter Review
Focus after lost focus ;)
Assignee: nobody → firefox
Status: NEW → ASSIGNED
Attachment #343842 - Flags: review?(mschroeder)
Attachment #343842 - Flags: review?(mschroeder) → review?(Berend.Cornelius)
Comment on attachment 343842 [details] [diff] [review]
Patch v1

patch works fine r=berend
Attachment #343842 - Flags: review?(Berend.Cornelius) → review+
patch pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/87e981a9076d
->fixed.

Thank you for your contribution!
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
-> VERIFIED

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081022 Lightning/1.0pre (build 20081022044623) Shredder/3.0b1pre ID:20081022030932
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.