348607 - locale.dir=rtl does not affect all UI elements in branch builds

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Simon Montagu :smontagu]

Screenshot coming up

Comment 1

[Simon Montagu :smontagu]

Attachment: Screenshot of current branch build with locale.dir=rtl and :root { direction: rtl; }

Comment 2

[Jay Goldman]

Looks like this is running on Linux so I'm not sure about the spacing issues, but it seems to basically be the search controls that aren't work properly. Pam seems to have fixed this on https://bugzilla.mozilla.org/show_bug.cgi?id=347400, but maybe it hasn't landed in branch yet (specifically see https://bugzilla.mozilla.org/attachment.cgi?id=233252)?

Comment 3

[Simon Montagu :smontagu]

It's also the forward and back buttons. 

Comment 4

[Simon Montagu :smontagu]

Attachment: Screenshot of Arabic nightly build on Windows

Here's a Windows screenshot made with Mozilla/5.0 (Windows; U; Windows NT 5.1; ar; rv:1.8.1b1) Gecko/20060813 BonEcho/2.0b1 (presumably also before the latest checkins for the search controls)

The back and forward arrows show the same problem here.

Comment 5

[Asaf Romano (gone)]

Attachment: Don't flip twice(!)

Also, fix the position of the search-bar drop marker.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 233630 [details] [diff] [review]
Don't flip twice(!)

a=beltzner on behalf of drivers for the mozilla 181 branch

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Er, uh, assuming that you get your r+ from mconnor, natch :)

Comment 8

[Asaf Romano (gone)]

1.8 branch:
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.33
mozilla/browser/themes/winstripe/browser/searchbar.css 1.3.8.14

Comment 9

[Bryan]

Could this checkin have added additional padding to the left and right sides of both the forward and backward toolbar icons?  If so it looks bad in the latest builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060816 BonEcho/2.0b1 ID:2006081606

~B

Comment 10

[Asaf Romano (gone)]

No.

Comment 11

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).