347504 - (NewThemeRTL) NewTheme problems in RTL locales

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Behnam Esfahbod [:zwnj]]

Here are some problems in GTK2-based theme of Fx2.0b1.

Comment 1

[Behnam Esfahbod [:zwnj]]

Attachment: Tab headers borders. Search bar inline button.

- The last tab doesn't have left border in RTL mode.
- Sometimes the tab left to the selected tab has wrong right border.

- Search button in search bar has left border instead of right border. (Non-GTK?)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Are these still problems now that the new theme has landed? Can you try a branch nightly?

Comment 3

[Behnam Esfahbod [:zwnj]]

I just checkout from CVS on Thu, Aug 3 and just enable pango.  Should I checkout and build again?

Comment 4

[Behnam Esfahbod [:zwnj]]

Attachment: Screenshot of nightly of Aug 10th in Persian locale

Comment 5

[Behnam Esfahbod [:zwnj]]

Attachment: Updated screenshot [GTK2]

* Search button is LTR
* Search-engine icon is too right
* Go button and address bar has too space
* Drop-down button of address bar is on LHS (is it because of RTL intl.css?)

Comment 6

[Reuven Gonen]

Attachment: fix searchbar for RTL

the changes in this document need to be applied in order to fix the searchbar look. i just don't have the time now to create a patch.

Comment 7

[Asaf Romano (gone)]

Reuven, see bug 350801 for the patch.

Comment 8

[Peter Kasting]

Lots of blocking bugs have been fixed; what's the current status of this bug?

Comment 9

[Behnam Esfahbod [:zwnj]]

Attachment: Updated Screenshot

Comment 10

[Behnam Esfahbod [:zwnj]]

Attachment: Updated Screenshot 2

Comment 11

[Behnam Esfahbod [:zwnj]]

Attachment: Updated Screenshot 2

Comment 12

[Behnam Esfahbod [:zwnj]]

Attachment: Updated screenshot

Comment 13

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).