348732 - getGREPathWithProperties() fails if temp path has spaces

Status: RESOLVED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[jhp (no longer active)]

If the temporary path has spaces, the "regedit" call in getGREPathFromRegKey() will fail.  The solution is to add quotes around the temp path.

Comment 1

[Eric Suen]

glue\standalone\nsXPCOMGlue.cpp already provide GRE_GetGREPathWithProperties API, why you need write it in Java? Beside, SWT for Windows provide some API for ready register information, use "regedit" call really kind unprofessional...

Comment 2

[jhp (no longer active)]

(In reply to comment #1)
> glue\standalone\nsXPCOMGlue.cpp already provide GRE_GetGREPathWithProperties

Using this would require the Java app that is embedding Mozilla to link against the XPCOMGlue shared library.  That would mean that the Java app would depend on native code, and wouldn't be cross platform.

The solution to this was to recreate some of the XPCOMGlue code in Java, so that a Java app only needs to link in MozillaInterfaces.jar (no native libraries).

> Beside, SWT for Windows provide some API
> for ready register information, use "regedit" call really kind
> unprofessional...

JavaXPCOM does not depend on SWT.  It is a generic Java library.  So those APIs are not useful.  I spent some time searching for a way to do this in standard Java, but the only thing I found was this 'regedit' code.  Yes, it is hacky, but there doesn't seem to be any way to do it in pure Java code.

Comment 3

[jhp (no longer active)]

Attachment: patch

This is the patch suggested by Dominik on the ATF newsgroup.  I tested it and it works well.

Comment 4

[Eric Suen]

(In reply to comment #2)
> Using this would require the Java app that is embedding Mozilla to link against
> the XPCOMGlue shared library.  That would mean that the Java app would depend
> on native code, and wouldn't be cross platform.

Without Mozilla, JavaXPCOM is useless. So I really don't understand what means
"That would mean that the Java app would depend on native code,
and wouldn't be cross platform.", you want embedding Mozilla but don't want your
Java app depend on native code? or menas GRE_GetGREPathWithProperties not works
on some platform like mozilla does?

GRE_GetGREPathWithProperties is in glue/standalone folder, which means it can
build as static link library, no other dll dependencies, Is it necessary that
JavaXPCOM must be in "pure" Java?

Comment 5

[jhp (no longer active)]

Checked in to trunk. ->FIXED

Comment 6

[jhp (no longer active)]

Comment on attachment 233854 [details] [diff] [review]
patch

Asking for 1.8.1 approval.  This patch is low risk, and XULRunner only.

Comment 7

[Mike Schroepfer]

Comment on attachment 233854 [details] [diff] [review]
patch

a=schrep for drivers - non-blocker but doesn't affect main build

Comment 8

[jhp (no longer active)]

Checked in to MOZILLA_1_8_BRANCH.