Closed
Bug 348854
Opened 18 years ago
Closed 18 years ago
warning C4715: 'nsWSRunObject::GetWSPointBefore' : not all control paths return a value
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
People
(Reporter: jhenry, Assigned: RyanVM)
References
()
Details
Attachments
(1 file)
1.80 KB,
patch
|
brettw
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060816 Minefield/3.0a1 While making a trunk build today, I noticed the following warning during linking: c:\mozillaroot\mozilla\editor\libeditor\html\nswsrunobject.cpp(2034) : warning C4715: 'nsWSRunObject::GetWSPointBefore' : not all control paths return a value I linked to the corresponding code in LXR, see the URL field. I'm building on WinXP with VS.NET 2005, and the following compiler flags: ac_add_options --enable-optimize="-O2 -GL -arch:SSE2 -GA"
Comment 1•18 years ago
|
||
Seems like a "return GetCharAfter(point, outPoint);" part of the patch for bug 345587 went missing, possibly due to a bad merge.
Assignee: nobody → brettw
Assignee | ||
Comment 2•18 years ago
|
||
Something like this?
Attachment #234833 -
Flags: superreview?
Attachment #234833 -
Flags: review?
Assignee | ||
Updated•18 years ago
|
Attachment #234833 -
Flags: superreview?(brettw)
Attachment #234833 -
Flags: superreview?
Attachment #234833 -
Flags: review?(brettw)
Attachment #234833 -
Flags: review?
Comment 3•18 years ago
|
||
Comment on attachment 234833 [details] [diff] [review] Add missing return back to else statement This code is correct on the 1.8 branch, I guess I messed up the merge to trunk.
Attachment #234833 -
Flags: review?(brettw) → review+
Comment 4•18 years ago
|
||
Comment on attachment 234833 [details] [diff] [review] Add missing return back to else statement I can't SR this.
Attachment #234833 -
Flags: superreview?(brettw) → superreview?(bryner)
Updated•18 years ago
|
Attachment #234833 -
Flags: superreview?(bryner) → superreview+
Comment 5•18 years ago
|
||
mozilla/editor/libeditor/html/nsWSRunObject.cpp 1.42
Updated•18 years ago
|
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•