Closed
Bug 348968
Opened 18 years ago
Closed 18 years ago
Show feed handlers icons in the handlers menupopup on windows too
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1)
Attachments
(2 files)
|
4.00 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
|
12.26 KB,
image/png
|
Details |
screenshot
We should show feed handler icons in the menupopup too, and not just the icon of the selected handler. On mac, we get this for free since the menupopup isn't styled as a dropdown. Patch coming.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #234176 -
Flags: review?(mconnor)
Attachment #234176 -
Flags: approval1.8.1?
|
|
Assignee | |
Comment 2•18 years ago
|
||
|
|
Assignee | |
Updated•18 years ago
|
Flags: blocking-firefox2?
Priority: -- → P1
|
||
Comment 3•18 years ago
|
||
Comment on attachment 234176 [details] [diff] [review] patch r+a=me for this branch-only fix. I tested this on a clean Windows branch build, looks great!
Attachment #234176 -
Flags: review?(mconnor)
Attachment #234176 -
Flags: review+
Attachment #234176 -
Flags: approval1.8.1?
Attachment #234176 -
Flags: approval1.8.1+
|
|
Assignee | |
Comment 4•18 years ago
|
||
1.8 branch: mozilla/browser/themes/winstripe/browser/feeds/subscribe.css 1.1.2.10 mozilla/browser/components/feeds/content/subscribe.xhtml 1.1.2.9 Trunk checkin will be done as part of the trunk checkin for bug 346009.
|
|
||
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
|
||
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•