Closed
Bug 349010
Opened 18 years ago
Closed 18 years ago
Remove selectAddresses.dtd
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
Sunbird 0.3
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(1 file)
6.53 KB,
patch
|
cmtalbert
:
first-review+
jminta
:
second-review+
|
Details | Diff | Splinter Review |
According to lxr, selectAddresses.dtd is no longer used. Looking at the .dtd itself, it doesn't look too useful in its current state. I'd like to stop packaging it and cvs rm it. codesize
Assignee | ||
Comment 1•18 years ago
|
||
The patch removes selectAddresses.dtd and removes references to it from 2 jar.mn files. LXR search for selectAddresses.dtd: http://lxr.mozilla.org/mozilla/search?string=selectAddresses.dtd
Attachment #234219 -
Flags: second-review?(jminta)
Attachment #234219 -
Flags: first-review?
Assignee | ||
Updated•18 years ago
|
Attachment #234219 -
Flags: first-review? → first-review?(cmtalbert)
Comment on attachment 234219 [details] [diff] [review] rev0 - removes selectAddresses.dtd from locales and from 2 jar.mns Looks good. Didn't build it (still downloading source on le mac). But, it looks simple enough to be OK.
Attachment #234219 -
Flags: first-review?(cmtalbert) → first-review+
Comment 3•18 years ago
|
||
Comment on attachment 234219 [details] [diff] [review] rev0 - removes selectAddresses.dtd from locales and from 2 jar.mns r=jminta
Attachment #234219 -
Flags: second-review?(jminta) → second-review+
Assignee | ||
Comment 4•18 years ago
|
||
Patch checked in on MOZILLA_1_8_BRANCH and trunk. Note that the "These files are Sunbird only..." comment lines were left in, as moving Lightning to use this jar.mn file will likely put a couple pref files back under that comment, at least until I fix bug 290747 (use sunbird.jar). -> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•