349054 - Visual Focus when tabbing out of Web Forgery popup

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Wayne DeAngelo]

Test environment:
   Windows XP, Firefox 2 (Bon Echo) build 20060815

Description:

On the "Suspected Web Forgery" popup, if you tab out of the warning pop-up window, visual focus is completely lost.  This happens when tabbing through the links on the grayed-out web page behind the security warning popup.


Steps to recreate:

1. Make sure the Google anti-phishing security option is set in the Firefox
security options.
    a. Open Firefox Tools, Options, and open Security page.
    b. Select "Tell me if the site I'm using is a suspected forgery" checkbox
    c. Select "Check by asking [Google] about each site I visit" radio button.
2. Open this web page URL in Firefox browser: 
http://www.google.com/tools/firefox/safebrowsing/phish-o-rama.html

- This results in the display of the "Suspected Web Forgery" pop-up.

3. Keep pressing the Tab key several times.  Focus moves to 
- the "Get me out of here!" button 
- then the "Ignore this warning" button 
- then the "Send report" button 
- then the Firefox Navigation toolbar Location field 
- then the Firefox Navigation toolbar Search field  
- then... where?  (no obvious visual focus showing anywhere)
- ... keep pressing Tab and eventually program focus returns to the "Suspected
Web Forgery" popup window links.

- It appears the program focus is tabbing through the links on the grayed-out
web page displayed behind the "Suspected Web Forgery" popup window.  None of
those focus changes can be seen visually.

Expected results:

1. The visual focus should be clear at all times. even when tabbing through the "grayed-out" page behind the security warning.  

Often, items that are grayed out are not accessible through the keyboard. In this case, the user should not be allowed to tab to items in the "grayed-out" page before a selection is made on the anti-phishing warning popup.

Comment 1

[Mark Pilgrim (inactive)]

Confirmed that this is a problem.  The antiphishing speech bubble should be modal; you shouldn't be able to tab out of it at all.  Just before beta1 there was a bug about setting initial focus on the bubble itself, which (IIRC) was sufficient to keep you in the bubble until you followed one of the bubble links.  Either my memory is faulty, or this pseudo-modalness has regressed.

Comment 2

[Tony Chang (Google)]

(In reply to comment #1)
> Confirmed that this is a problem.  The antiphishing speech bubble should be
> modal; you shouldn't be able to tab out of it at all.  Just before beta1 there
> was a bug about setting initial focus on the bubble itself, which (IIRC) was
> sufficient to keep you in the bubble until you followed one of the bubble
> links.  Either my memory is faulty, or this pseudo-modalness has regressed.

I think the pseudo-modalness has regressed.  In an earlier version we had set the collapsed property of browser to true which resulted in not being able to focus links in the browser.  This isn't the case anymore so focus can slip over.

I'll try to look for ways to prevent this.

Comment 3

[Aaron Leventhal]

Possibly related to bug 348368.

Comment 4

[:Gijs (he/him)]

Has there been any progress on this? Does setting collapsed or perhaps tabindex=0 help?

Comment 5

[Tony Chang (Google)]

This will probably be fixed when we switch to using content error pages (bug 399233).

Comment 6

[:Gijs (he/him)]

Yup, I can track focus everywhere now, when surfing to the example page given in the URL of bug 399233 (and tabbing around the content error page).

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381